Conversation
Member
davidism
added
the
rejected AI
davidism
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AliasedGroupexample overridesresolve_commandand doesreturn cmd.name, cmd, args. During shell completion (resilient parsing) of an unknown or mistyped command, the baseGroup.resolve_commandreturnscmd = None, socmd.nameraisesAttributeError: 'NoneType' object has no attribute 'name'.Click's base
Group.resolve_commandalready guards this withcmd_name if cmd else None; this change makes the example do the same (return cmd.name if cmd else None, cmd, args). The identical bug is in the runnableexamples/aliases/aliases.py, fixed here too.Verified on click 8.4.2 (Python 3.14): the current example raises the AttributeError during completion of an unknown command; with the fix, completion returns the expected results.
Closes #2402.