AI junk - #3784
Closed
tunglambk wants to merge 2 commits into
Closed
Conversation
Member
davidism
added
the
rejected AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2645
Lazy read-mode
Fileparameters validated their path by opening and closing it during conversion. For a FIFO, that eager reader can consume the writer's data before the command accesses the lazy file.Skip the eager open for FIFO paths while preserving it for regular readable paths. The regression test asserts that constructing a lazy FIFO reader does not open the FIFO, and the changelog records the behavior change.
Tests:
uv run pytest -quv run ruff check src/click/utils.py tests/test_utils/test_LazyFile.pyuv run ruff format --check src/click/utils.py tests/test_utils/test_LazyFile.pyuv run --group docs sphinx-build -E -W -b dirhtml docs docs/_build/dirhtml