Deduplicate deprecated label translation#3430
Merged
Rowlando13 merged 2 commits intoMay 16, 2026
Merged
Conversation
kdeldycke
force-pushed
the
deduplicate-deprecated-message
branch
from
43f5e77 to
c040135
Compare
ic
reviewed
May 18, 2026
Contributor
ic
left a comment
ic
left a comment
There was a problem hiding this comment.
Thank you for sharing. Nice for consistent formatting. One question, perhaps leading to simpler type signature.
| raise RuntimeError(message) | ||
|
|
||
|
|
||
| def _format_deprecated_label(deprecated: bool | str) -> str: |
Contributor
There was a problem hiding this comment.
For my understanding, why the bool argument type option in the two new helpers? Not used in the body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small bugfix PR at #3423 hinted at inconsistencies in the way deprecated messages were produced and translated.
We discussed these message translation on PR #2902 , which reminded me of duplicate messages.
Turns out we can deduplicate these messages with some simple helper.
CC @sjoubert @ic @v--