feat: integrate Agentic-QE external providers - #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm run checkpnpm run test:aqe-external-provider-live: passed against installed Agentic-QE 3.13.12; real CLI + MCP JSON-RPC generation invoked the admitted providergit diff --checkReview evidence
Agentic-QE brutal-honesty review produced and this branch fixed weighted findings for stale provider snapshots (8/10), unbounded timeout/concurrency (7/10), and unbounded/control-bearing metadata (5/10), plus subsequent adversarial findings around environment casing, secret/output boundaries, revocation convergence, ownership drift, downgrade truthfulness, and write idempotence.
Final QE-Court receipt for
67bb0fb8444a43896b4064c3673b0b759b272c60:SHIP, no surviving chargesopenai/gpt-4o2df1d3b7f8eb2dc70d29d1b8ac76022fc7ed7e2d744cd7e23786f2a03110b692UPHOLD(200/200 focused tests)UPHOLD(201/201 focused + live tests and an independent receipt-mutation matrix)The final mutation matrix covers unchanged managed defaults; user replacements inside and outside the old chain; a second admitted external provider; null, malformed, wrong-provider, and wrong-hash receipts; and repeat byte/mtime stability.
Upstream boundary
This PR proves the supported Agentic-QE 3.13.12 MCP generation path. It deliberately does not claim
aqe llm advise --provider <external>: upstream 3.13.12 constructs itsProviderManagerbefore loading project external-provider configuration for that command. No downstream integration remains pending for the #628 MCP surface implemented here.