feat: integrate deja-vu as a managed companion - #182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #114.
Integrates deja-vu as an opt-in, Kit-managed companion rather than a host or provider:
integrations.dejaVuconfiguration contract, companion registry entry, and strict v0.19.0 health/target parsers--with-deja-vu,--deja-vu-mode,--no-deja-vu) with exact-host installation and one bounded index passAdjustments for deja-vu v0.19.0
The issue was filed against older behavior. This implementation follows the issue author's later guidance and the published v0.19.0 contract:
@vshulcz/deja-vu >= 0.19.0and validatesdoctor --json --offlineschema version 2--no-guidance --no-index; it never uses aggregate--all/--autotargetsdeja updatedeja indexafter target installation because v0.19.0warmupalso writes guidanceDEJA_INDEX_DIRpath, including arbitrarily named overrides, while preserving siblings during purgeSafety and ownership
Validation
pnpm run check— typecheck, ESLint, markdownlint, packaging/build validation, and full Node test suite passgit diff --checkpasses@vshulcz/deja-vu@0.19.0live smoke: isolateddoctor --json --offlineparsed successfully as schema 2 with an exact custom index directoryIndependent quality review
The brutal-honesty pass found and this branch resolved:
Agentic-QE v3.13.12 was used directly. Its security scan raised one apparent
eval/execfinding; inspection confirmed it is a false positive on a regular-expressionRegExp.execcall. Its coverage analyzer reported no ingested coverage data, so coverage claims above come from the repository's real enforced test gate, not that analyzer. The semantic adviser could not run because its configured providers required an unavailable pay-per-token budget/API key.The QE-Court survey validated the machine-level multi-vendor panel structure, but the repository has no consumer QE-Court panel/projection. Per the court contract, the court was therefore not convened and no SHIP/REMAND/BLOCK verdict is claimed; a human reviewer remains the final judge.
Residual review note
The two new core companion modules are slightly above the repository's approximate 500-line guidance. They remain cohesive and fully gated, but are candidates for a later readability-only extraction if maintainers prefer smaller modules.