Skip to content

Fix vertical alignment of icons#440

Open
BenjaminSchaaf wants to merge 1 commit into
packagecontrol:gh-pagesfrom
sublimehq:icon-alignment
Open

Fix vertical alignment of icons#440
BenjaminSchaaf wants to merge 1 commit into
packagecontrol:gh-pagesfrom
sublimehq:icon-alignment

Conversation

@BenjaminSchaaf

Copy link
Copy Markdown
Contributor

Before:

Screenshot from 2026-06-24 18-05-59

After:

Screenshot from 2026-06-24 18-06-13

@kaste

kaste commented Jun 24, 2026

Copy link
Copy Markdown
Collaborator

This seems wrong as there is no vertical-align: center;

image

On my machine after looks like

image

@michaelblyons

Copy link
Copy Markdown
Contributor

Does it look okay if you change center to middle?

https://developer.mozilla.org/en-US/docs/Web/CSS/Reference/Properties/vertical-align

@BenjaminSchaaf

Copy link
Copy Markdown
Contributor Author

Ah, vertical-align: center is a firefox-ism, and doesn't do the same as middle. Seems the modern approach is to use flexbox.

@BenjaminSchaaf

Copy link
Copy Markdown
Contributor Author

I've pushed a fix for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants