feat: add spec conformance tests - #274
Open
nscuro wants to merge 2 commits into
Open
Conversation
As per https://github.com/package-url/purl-spec/blob/65eeef85de5637ffed26695ffd753202b6a4d656/docs/specification/standard/specification.md#character-encoding: ``` The following characters shall not be percent-encoded: ... * the colon ':', whether used as a Separator Character or otherwise ``` Signed-off-by: nscuro <nscuro@protonmail.com>
Tests the implementation against the spec's official conformance test suite. The spec is included as git submodule to make versioning and updating easier. A handful of tests are failing. I opted to document them as known failures for now. Fixes for those should ship separately. Note that only tests of the `required` group are executed currently, because the library lacks a differentiation between strict and lenient parsing, which tests of the `recommended` group require. We should implement that later. Signed-off-by: nscuro <nscuro@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Based on #273, which should be merged first.
Tests the implementation against the spec's official conformance test suite. The spec is included as git submodule to make versioning and updating easier.
A handful of tests are failing. I opted to document them as known failures for now. Fixes for those should ship separately.
Note that only tests of the
requiredgroup are executed currently, because the library lacks a differentiation between strict and lenient parsing, which tests of therecommendedgroup require. We should implement that later.