feat: enforce null-safety at compile time - #272
Open
nscuro wants to merge 1 commit into
Open
Conversation
nscuro
changed the title
Adds NullAway to enforce null-safety (which is already declared using JSpecify) at compile time. Had to replace a few `StringUtil#isEmpty` calls with inlined versions to allow NullAway to "see" the null-check. Note that NullAway is only enabled for production code, and explicitly disabled for test code. This is because you usually want to violate null-safety in tests. Signed-off-by: nscuro <nscuro@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds NullAway to enforce null-safety (which is already declared using JSpecify) at compile time.
Had to replace a few
StringUtil#isEmptycalls with inlined versions to allow NullAway to "see" the null-check.Note that NullAway is only enabled for production code, and explicitly disabled for test code. This is because you usually want to violate null-safety in tests.