Five small audit findings: honest fault-C gate, anchored wipe verdict, data-reset + hugepage coverage, installer mount trap - #928
Merged
Conversation
…pe verdict, data-reset + hugepage coverage, installer mount trap - fault C asserted only the absence of 'panic'; an installer that ACCEPTED the corrupted bundle read as a pass. Gate on the install's exit status. - the wipe=data verdict grep matched 'verdict=OK' inside 'verdict=OK,USER-DATA-SURVIVED' — anchored to the exact line. - pithead-data-reset (the shell-less box's last-resort recovery) had zero verify-image coverage; unit/enablement/script/ordering now pinned. - the load-bearing hugepage sysctl had no static or boot coverage; the bake is pinned and the boot phase reads /proc/meminfo. - pithead-install's wipe=data left the partition mounted-busy if a step failed mid-move (its EXIT trap installs later in main) — a scoped expand-now trap releases it for the retry. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The audit wave's confirmed small findings, applied together before the KVM battery run so the battery exercises the sharpened asserts:
verdict=OK,USER-DATA-SURVIVEDcontainsverdict=OKand passed. Anchored withgrep -qx.make lintgreen; bash -n on all three files; the fault-C and wipe legs get their live proof in the battery run queued next. Ponytail: five one-site changes, nothing speculative.🤖 Generated with Claude Code