refactor(pithead): reuse onion_missing() at its four inline call sites - #920
Merged
Conversation
The onion-missing check (empty or still the shipped "placeholder") was already a named helper and already called in two places, but hand-written inline in four others: stack_upgrade's post-upgrade onion capture, doctor's onion-address report, provision_onion_client_auth's pubkey check, and apply's post-recreate onion capture. Swap each for onion_missing() so the placeholder-check logic can't drift from the canonical definition. No behavior change — same boolean expression, now shared. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplification-audit finding, applied:
onion_missing()already existed and was already used at four sites, while the identical compound condition ([ -z ... ] || [ ... == placeholder ]) was hand-written inline at four others. All four now call the helper. Byte-for-byte the same decisions; the stack suite pins them (2171/0). Verifier pass: clean.🤖 Generated with Claude Code