chore(os): shared loop-partition wait, drop the dead --vm flag - #919
Merged
Conversation
tests/os/run.sh parsed --vm but nothing called it, and it was incomplete anyway — DISK/SERIAL never keyed off it, so two runs with different --vm values would still collide on the same scratch disk. mkimage.sh and verify-image.sh each carried the same nine-line wait for a loop device's partition nodes to appear after `losetup -P`, worded identically down to the comment cross-referencing the other copy. Pulled the polling loop into os/rauc/loop-wait.sh (sourced by both), following the precedent populate-slot.sh already sets; each caller keeps its own error message. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Cosmetic — the file is sourced either way. Keeps the two shared os/rauc/*.sh helpers consistent. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two confirmed findings from the simplification audit, applied:
mkimage.shandverify-image.sh(and had already drifted in wording). Now one 8-linewait_loop_partitionsinos/rauc/loop-wait.sh, sourced by both — the same sharing precedentpopulate-slot.shset; callers keep their own error messages. Ponytail round two shrank the helper itself: both callers want exactly p1+p2 (ESP + slot A is the image's whole layout), so the variadic suffix loops went too.tests/os/run.sh --vmwas parsed but documented nowhere and called by nothing — deleted; the VM name stays the hardcoded default it always effectively was.Behaviour preserved exactly;
make lintgreen; verifier pass on the branch confirmed no observable difference (its one finding was an implementer test-claim overreach, corrected in this description: markdownlint noise it saw came from a stale base, and the current base lints clean).🤖 Generated with Claude Code