Project hygiene: #898 donation-cap fix, gap-review doc corrections, research under docs/, lean-downs - #907
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…); docs corrections; simplifications The dwell catch-up compared the credited 1h average against the raw tier target, so an explicit target the fleet cannot sustain read as permanently under-tier, ended every p2pool dwell at its first check tick, and pinned the actuated donation near 100% of allowed time — the configured cap never bound (measured live: ~94% routed under a 0.65 cap). The catch-up now chases min(target, stable_hr x max_donation_fraction): nothing to catch up to beyond what the cap allows. Three-case regression test. Also: twenty verified documentation corrections from the project gap review (release branch mechanics + withdrawal procedure + honest staging- smoke description + stage-2 gate value; stale testing-strategy/guide passages; service counts; config reference completeness; study cross- links; restore-path and host-port hazards), and two lean-downs from the whole-tree over-engineering audit (dead demo block; coin formatter consolidation). Closes #898. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
27 false positives — hex example IDs and page-chrome tokens inside checksummed third-party page archives that must stay byte-identical. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
CI scans full history, where the archives exist at both research/... and docs/research/...; verified clean in git-history mode locally. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Aug 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The consolidated output of the project-wide review (release procedure, testing, documentation, implementation debt) plus the whole-tree over-engineering audit.
Code
min(target, stable_hr × max_donation_fraction). Three-case regression test.__main__demo block deleted;format_xmr/format_xtmconsolidated. (Declined with reasons: CI container-test job — env-parity guard; cross-harness assert dedup — churn over value; CLI micro-inlines — one broke a contract test and was reverted.)Docs (20 verified gap-review corrections)
Release: branch mechanics (cut from main, real merge, back-merge) now written down; honest staging-smoke description; the stage-2
RELEASE_INTEGRATION_ARGSvalue; a withdrawal procedure (v1.6.0 precedent, tag-ruleset verified live); the operator-run e2e gate made explicit. Testing: stale #563 and monerod-down passages fixed; the visual-harness recipe documented. Reference: service count 9→11 with the profile-gated wallets tabled; four missing config keys +raffle_winevent; key count recounted (113); study cross-linked; restore-path and host-port hazards documented.Organization
docs/research/xvb-delivery-study/(lint carve-outs re-pointed).Companion issues filed for the large gaps: #902–#906; #880 updated with the root-caused fix ingredient.
Full verification: lint green across all surfaces, 1,696 stack tests, full pytest, 274 frontend tests, patch coverage 100%.
🤖 Generated with Claude Code