Merged
Conversation
adzialocha
force-pushed
the
adz/fix-tests
branch
from
d44b443 to
876afa7
Compare
adzialocha
force-pushed
the
adz/fix-tests
branch
5 times, most recently
from
2d6e72f to
53568eb
Compare
adzialocha
changed the title
adzialocha
force-pushed
the
adz/fix-tests
branch
5 times, most recently
from
49c10ba to
9adc524
Compare
The "build" GitHub action is currently failing and requires a lot of time / resources. Until this is fixed this patch sets it to manual dispatch. It can be triggered now manually from the GitHub UI.
The tests have actually not worked due to API changes which were not updated yet in the tests modules. This was not noticed since we're not running tests in CI. This patch fixes the tests by: 1. Updating the tests to use the latest method signatures 2. Await results due to async behaviour of system
adzialocha
force-pushed
the
adz/fix-tests
branch
from
9adc524 to
074a7f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38