Ao3-7534 media category tag pages edit#5946
Open
Mangooomango wants to merge 2 commits into
Open
Conversation
Issue https://otwarchive.atlassian.net/browse/AO3-7534 Purpose Instead of always showing "You can use it to filter works and to filter bookmarks" for all Media Category tag pages, it will only show it to then filterable ones. It will show "It's a %{canonical_tag_link}." to no filters. Testing Instructions 1. Go to Media Category tags for Theater, Anime, and Manga. 2. Check that it says "It is a canonical tag." instead of "You can use it to filter works and to filter bookmarks." 3. Go to canonical tag for different category 4. Check that it says "You can use it to filter works and to filter bookmarks." If you have a Jira account with access, please update or comment on the issue with any new or missing testing instructions instead. You can remove this section if there are already full testing instructions in the Jira issue. Credit Mango (She/her)
Issue https://otwarchive.atlassian.net/browse/AO3-7534 Purpose Instead of always showing "You can use it to filter works and to filter bookmarks" for all Media Category tag pages, it will only show it to then filterable ones. It will show "It's a %{canonical_tag_link}." to no filters. Testing Instructions 1. Go to Media Category tags for Theater, Anime, and Manga. 2. Check that it says "It is a canonical tag." instead of "You can use it to filter works and to filter bookmarks." 3. Go to canonical tag for different category 4. Check that it says "You can use it to filter works and to filter bookmarks." If you have a Jira account with access, please update or comment on the issue with any new or missing testing instructions instead. You can remove this section if there are already full testing instructions in the Jira issue. Credit Mango (She/her)
Collaborator
|
Hi, Mango -- welcome back! It looks like you already have an open pull request for a First Timers Only issue: #5519, which needs action before it can be merged. We ask that each contributor only work on one First Timers Only issue, so we'd appreciate it if you would close one of these two pull requests. Once you've done that, we'll be happy to review the open pull request. We're also still happy to set you up with Jira permissions as discussed on #5519, so please let us know if that's something you'd be interested in. Thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7534
Purpose
What does this PR do?
Instead of always showing "You can use it to filter works and to filter bookmarks" for all Media Category tag pages, it will only show it to then filterable ones. It will show "It's a %{canonical_tag_link}." to no filters.
Testing Instructions
If you have a Jira account with access, please update or comment on the issue with any new or missing testing instructions instead.
If you have a Jira account with access, please update or comment on the issue
with any new or missing testing instructions instead.
You can remove this section if there are already full testing instructions in the Jira issue.
Credit
Mango (she/her)
If you have a Jira account, please include the same name in the "Full name"
field on your Jira profile, so we can assign you the issues you're working on.
Please note that if you do not fill in this section, we will use your GitHub account name and
they/them pronouns.