AO3-7506 Add backfill task for missing username pseuds#5936
Open
pmonfort wants to merge 2 commits into
Open
Conversation
sarken
reviewed
Jul 25, 2026
sarken
left a comment
Collaborator
There was a problem hiding this comment.
Drive-by question! What happens if the user login is Name and they have
- the pseud name (but not Name)
- the pseud Näme (but not Name)
Should we be testing those scenarios, since they're the ones that would've led the user to be able to delete the default pseud prior to PR #5534?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AO3-1234 Fix thing)Issue
https://otwarchive.atlassian.net/browse/AO3-7506
Purpose
Adds an
After:backfill_missing_pseudsrake task that finds users who don't have a pseud matching their current username and creates one.This covers the ~100 users who deleted their username-matching pseud before the fix in AO3-6359 (PR #5534) was deployed.
One difference from the SQL in the ticket: I added
AND pseuds.user_id = users.idto the subquery. Without it, if another user happens to have a pseud with the same name as the affected user's login, the query would miss that user.Testing Instructions
Testing instructions are in the Jira issue.
References
Credit
Pablo Monfort (he/him)