Skip to content

AO3-7506 Add backfill task for missing username pseuds#5936

Open
pmonfort wants to merge 2 commits into
otwcode:masterfrom
pmonfort:AO3-7506
Open

AO3-7506 Add backfill task for missing username pseuds#5936
pmonfort wants to merge 2 commits into
otwcode:masterfrom
pmonfort:AO3-7506

Conversation

@pmonfort

Copy link
Copy Markdown
Contributor

Issue

https://otwarchive.atlassian.net/browse/AO3-7506

Purpose

Adds an After:backfill_missing_pseuds rake task that finds users who don't have a pseud matching their current username and creates one.

This covers the ~100 users who deleted their username-matching pseud before the fix in AO3-6359 (PR #5534) was deployed.

One difference from the SQL in the ticket: I added AND pseuds.user_id = users.id to the subquery. Without it, if another user happens to have a pseud with the same name as the affected user's login, the query would miss that user.

Testing Instructions

Testing instructions are in the Jira issue.

References

Credit

Pablo Monfort (he/him)

@sarken sarken left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drive-by question! What happens if the user login is Name and they have

  • the pseud name (but not Name)
  • the pseud Näme (but not Name)

Should we be testing those scenarios, since they're the ones that would've led the user to be able to delete the default pseud prior to PR #5534?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants