Skip to content

fix: parse oauth auto redirect environment flag - #719

Merged
krokosik merged 1 commit into
oss-apps:mainfrom
joshtgl:fix/parse-oauth-auto-redirect-env
Aug 4, 2026
Merged

fix: parse oauth auto redirect environment flag#719
krokosik merged 1 commit into
oss-apps:mainfrom
joshtgl:fix/parse-oauth-auto-redirect-env

Conversation

@joshtgl

@joshtgl joshtgl commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Description

Last update to parse the new OAUTH_AUTO_REDIRECT value with the parseEnvBoolean function.

Checklist

  • I have read CONTRIBUTING.md in its entirety
  • I have performed a self-review of my own code
  • I have added unit tests to cover my changes
  • The last commit successfully passed pre-commit checks
  • Any AI code was thoroughly reviewed by me

Summary by CodeRabbit

  • Bug Fixes
    • Improved handling of the automatic OAuth redirect setting by consistently interpreting its configured true/false value.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: cb197783-ab94-4c41-9a6e-2c085862bf04

📥 Commits

Reviewing files that changed from the base of the PR and between 13495df and f151eb0.

📒 Files selected for processing (1)
  • src/env.ts

📝 Walkthrough

Walkthrough

OAUTH_AUTO_REDIRECT now uses the shared parseEnvBoolean helper in src/env.ts.

Changes

OAuth environment parsing

Layer / File(s) Summary
Use shared boolean parser
src/env.ts
OAUTH_AUTO_REDIRECT now uses parseEnvBoolean instead of direct JSON.parse handling.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: krokosik

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the change to environment flag parsing.
Description check ✅ Passed The description summarizes the change and completes the checklist, but it omits the optional Demo section and confirms that no tests were added.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@krokosik
krokosik merged commit 957dab7 into oss-apps:main Aug 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants