fix: omit unsupported $top query option on chat members list#28
Open
amanjoshicodes wants to merge 1 commit into
Open
fix: omit unsupported $top query option on chat members list#28amanjoshicodes wants to merge 1 commit into
$top query option on chat members list#28amanjoshicodes wants to merge 1 commit into
Conversation
Contributor
|
Firstly thank you @amanjoshicodes - we will check this today / tomorrow 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27.
teams chat members list <chat-id>failed with HTTP 400 becausechats::list_membersappended$toptoGET /chats/{id}/members, which doesn't support OData query parameters. Microsoft Graph rejects the request withQuery option 'Top' is not allowed.This routes
list_membersthrough the existingGraphClient::get_paged_without_top— added in #24 for the same class of bug onlist_channels— so the request pages via@odata.nextLinkwithout$top.Changes
chats::list_membersnow delegates to a privatelist_members_at(url, ...)helper that callsget_paged_without_top, mirroring thelist_channels/list_channels_atshape introduced in Fix channel list pagination query #24.wiremockunit testlist_members_omits_top_query_parameterasserting the outgoing request carries no$top(matches thelist_channels_omits_top_query_parametertest).Verification
cargo fmt --all,cargo clippy --all-targets -- -D warnings,cargo test --all-targets— all green (76 unit + 44 integration).teams chat members list <chat-id>now returns members instead of a 400.Scope is intentionally limited to chat members. Team members and channel members both document
$topsupport, so they're unchanged.