Skip to content

fix: language condition in custom email template - #2705

Open
vinckr wants to merge 1 commit into
ory:masterfrom
diegosteiner:patch-1
Open

vinckr wants to merge 1 commit into
ory:masterfrom
diegosteiner:patch-1

Conversation

@vinckr

@vinckr vinckr commented Sep 15, 2026

Copy link
Copy Markdown
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Copilot AI lite review requested due to automatic review settings September 15, 2026 12:49
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The reviewed change is correct and has no unresolved issues.

Pull request overview

Fixes the malformed language conditional in the custom email template example.

Changes:

  • Replaces the standalone else if with a valid if condition.
  • Corrects French, German, and English template selection.
File summaries
File Description
docs/kratos/emails-sms/05_custom-email-templates.mdx Corrects language-based template selection.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants