Skip to content

chore: upgrade and prune dependencies#439

Merged
alnr merged 3 commits into
masterfrom
alnr/modernize2
May 29, 2026
Merged

chore: upgrade and prune dependencies#439
alnr merged 3 commits into
masterfrom
alnr/modernize2

Conversation

@alnr
Copy link
Copy Markdown
Collaborator

@alnr alnr commented May 29, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Enhanced error handling for session validation failures with improved error wrapping.
  • Chores

    • Simplified build configuration by removing unnecessary build flags.
    • Upgraded multiple dependencies to latest stable versions for improved compatibility and performance.

Review Change Stack

@alnr alnr self-assigned this May 29, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

📝 Walkthrough

Walkthrough

This PR removes conditional build tags from the Makefile, migrates UUID imports from the versioned module to the non-versioned module, improves error handling in session checks, and updates the Go dependency graph across direct and transitive dependencies.

Changes

Build system, imports, and dependency updates

Layer / File(s) Summary
Makefile build tag removal
Makefile
Build targets .bin/cli, install, and refresh are updated to remove -tags sqlite and -tags sqlite,json1 invocations.
UUID import migration from v3 to base module
cmd/cloudx/oauth2/client_test.go, cmd/cloudx/proxy/helpers.go, go.mod
UUID imports are switched from github.com/gofrs/uuid/v3 to github.com/gofrs/uuid in both client_test.go and helpers.go, and the go.mod direct requirement is updated to reflect this migration.
Session error handling improvements
cmd/cloudx/proxy/helpers.go
Error handling in checkSession is refactored to use herodot.ErrInternalServerError() as a callable and consistently chain WithReasonf() and WithWrap() for both request creation failures and JSON decode failures.
Transitive dependency updates
go.mod
Indirect dependencies are refreshed with version bumps across grpc-ecosystem packages (middleware v2, grpc-gateway v2), databases/SQL drivers, OpenTelemetry, and supporting libraries.

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request has no description provided, missing all required sections including the big picture summary, related issues, and checklist confirmations. Add a comprehensive description explaining the dependency upgrades, any breaking changes, testing performed, and complete the required checklist items from the template.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: upgrade and prune dependencies' accurately reflects the main changes in the PR, which involve updating multiple dependencies in go.mod and adjusting build tags in the Makefile.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch alnr/modernize2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@cmd/cloudx/proxy/helpers.go`:
- Line 379: Replace the bare return of
errors.WithStack(herodot.ErrInternalServerError()) on request-creation failure
with the same chained form used for JSON-decode failures: call
errors.WithReasonf("request creation failed: %s", someContext).WithWrap(err) (or
similar descriptive reason) instead of WithStack, ensuring you pass the original
error variable (err) into WithWrap so the error retains diagnostic context and
use herodot.ErrInternalServerError() as the base error like the other cases.

In `@Makefile`:
- Line 16: The Makefile build/test targets were changed to remove the build
tags, causing a mismatch with .docker/Dockerfile-build (which still uses -tags
sqlite,json1) and CONTRIBUTING.md (which references go test -tags sqlite ./...),
so restore tag consistency: update the Makefile targets that run go build and go
test (the lines invoking "go build -o .bin/cli github.com/ory/cli" and the other
build/test targets around lines referenced) to include the same -tags
sqlite,json1 flags, or alternatively update .docker/Dockerfile-build and
CONTRIBUTING.md in this PR to remove sqlite/json1 references — pick one approach
and apply it consistently to all build/test entrypoints so the build/test tag
matrix matches across Makefile, Dockerfile-build, and docs.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4b0fbccd-fbc8-4dd4-882b-74b80dbc1113

📥 Commits

Reviewing files that changed from the base of the PR and between 1e51407 and 937bfa8.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (4)
  • Makefile
  • cmd/cloudx/oauth2/client_test.go
  • cmd/cloudx/proxy/helpers.go
  • go.mod

Comment thread cmd/cloudx/proxy/helpers.go
Comment thread Makefile
@alnr alnr merged commit 3ef403b into master May 29, 2026
19 checks passed
@alnr alnr deleted the alnr/modernize2 branch May 29, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant