refactor(ui): unify dropdown action rows#526
Open
beruro wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DropdownItemwith action-menu role, width, focus, label, and submenu-state propsValidation
pnpm exec tsc --noEmit --pretty falsegit diff --checkFrontend UI audit
6 fixes applied, 3 patterns kept with documented reasons, 0 new abstraction candidates. A systematic follow-up candidate records 23 remaining
menuActionItemsites; they include submenu/control variants and were not converted site-by-site in this PR. Full report:docs/frontend-ui-audit-2026-07-24/DropdownActionRows.md.Architecture audit
Covered compilation, shared interaction ownership, role/selection semantic separation, disabled/error parity, and caller migration. No persistence, wire protocol, resolver, or background lifecycle behavior changes.