CompatHelper: add new compat entry for OrderedCollections at version 1, (keep existing compat)#4
Open
github-actions[bot] wants to merge 1 commit into
Conversation
…1, (keep existing compat)
orebas
added a commit
that referenced
this pull request
Jun 12, 2026
…corrections P0#2 verified a FALSE POSITIVE: the installed HomotopyContinuation.jl defaults are only_nonsingular=false, only_finite=true (result.jl:230-255), so the bare solutions(result) call already kept singular roots and excluded at-infinity endpoints — no Inf solutions were possible. Hardened regardless: kwargs now explicit (pinned against upstream default changes, consistent with the file's other call sites) and the projection loop drops any non-finite vector defensively. Review doc updated: #2 marked false-positive/hardened; #4 marked fixed with the real root cause (lookup_value, not the ring-name parse sites the review flagged). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request sets the compat entry for the
OrderedCollectionspackage to1.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
Note: Consider registering a new release of your package immediately after merging this PR, as downstream packages may depend on this for tests to pass.