[GR-61894] Eagerly initialize native thread state.#726
Merged
graalvmbot merged 14 commits intomasterfrom Apr 7, 2026
Merged
Conversation
This reverts commit 33d13f7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change cleans up C API initialization state handling. In particular, the native
PyThreadStatewill be initialized eagerly (best effort).Unfortunately, if a thread is currently in a blocking I/O operation or something, we cannot wait for it to be finished. Therefore, we keep a fallback that lazily initializes the native thread state. The fallback is very unlikely because the initialization is submitted as thread-local action and most likely runs before any C extension function is called.
The main changes are:
initialize_graal_capi) on the initializing (usually the main) thread.CApiContext.initializeThreadStateCurrentForAttachedThreads(...)).PythonContext.attachThread.GCStateandPyThreadStateinit liek CPython does. With that, reentrancy of the native thread state init is no longer possible.This was motivated by a rare transient failure in C extensions where upcall
PyTruffleThreadState_Gethit an assertion while trying to publish the address of the native TLS during lazy init of the native thread state.The underlying issue was that thread-local
tstate_currentinitialization on non-main threads was lazy and could re-enter the publication path. The new setup makes that initialization explicit and one-time per thread.