Raise a new file not found error when loading queries#950
Raise a new file not found error when loading queries#950ogenstad merged 1 commit intoinfrahub-developfrom
Conversation
Deploying infrahub-sdk-python with
|
| Latest commit: |
3305f85
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://07417e2d.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://pog-filenotfound-on-load-que.infrahub-sdk-python.pages.dev |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThis pull request introduces a new exception class 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## infrahub-develop #950 +/- ##
====================================================
+ Coverage 81.09% 81.11% +0.01%
====================================================
Files 134 134
Lines 11306 11314 +8
Branches 1693 1693
====================================================
+ Hits 9169 9177 +8
Misses 1594 1594
Partials 543 543
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Why
If a user has an
.infrahub.ymlfile with a query section and the file for one of those queries are missing the error message isn't very helpful. Here we instead catch the file not found error and raise a custom SDK error that the backend will catch.What changed
Summary by CodeRabbit
New Features
Tests