Merge stable into develop - #1242
Merged
Merged
Conversation
) add(), subtract() and add_delta() all construct self.__class__, so a subclass gets an instance of itself back at runtime. The annotations said Timestamp, so subclasses (such as Infrahub's own Timestamp) had to cast before touching anything they add on top. Self comes from typing_extensions rather than typing, since typing.Self is 3.11+ and the SDK supports 3.10. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Deploying infrahub-sdk-python with
|
| Latest commit: |
91bcbcb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://98a484f6.infrahub-sdk-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging stable into develop after merging pull request #1241.
Summary by cubic
Return types for
Timestamp.add(),Timestamp.subtract(), andTimestamp.add_delta()now useSelfinstead ofTimestamp, aligning annotations with runtime behavior and eliminating casts for subclasses. Runtime behavior and deprecation warnings are unchanged.Selffromtyping_extensionsto support Python 3.10.Written for commit 91bcbcb. Summary will update on new commits.