Merge stable into develop - #1238
Merged
Merged
Conversation
…ame (#1233) The marker was registered as `infrahub_integraton`, with a missing `i`, but the loader applies `infrahub_integration`. So the marker we really use was never registered, and the one we registered was never used. The description carried the same kind of typo, `Integation`. Integration tests raised a `PytestUnknownMarkWarning` on every run, and collection failed under `--strict-markers`. `pytest --markers` also listed a marker that nothing applies, which misleads anyone selecting tests by marker. Turn on `--strict-markers` for our own test run so an unregistered marker fails the build instead of passing with a warning nobody reads. Two tests guard the marker names. The type markers are applied while collecting, so `--strict-markers` rejects an unregistered one. The resource markers cannot be checked that way: `MARKER_MAPPING` is built when the loader is imported, so those marks exist before a config is attached, and `MarkGenerator` only validates a mark once it has one. Those are compared against the registered list instead, with the expected names taken from `MARKER_MAPPING`, so a new resource marker is covered on its own. Fixes #1231
…docs docs: update compatibility matrix
github-actions
Bot
added
the
type/documentation
Deploying infrahub-sdk-python with
|
| Latest commit: |
f2eb9e2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://35d96537.infrahub-sdk-python.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging stable into develop after merging pull request #1237.
Summary by cubic
Register the
infrahub_integrationpytestmarker under its real name and enable--strict-markerswith tests to catch unregistered markers. Update the compatibility matrix to include Infrahub 1.10.7 → SDK 1.22.2.Written for commit f2eb9e2. Summary will update on new commits.