fix(pkg/validation/internal): check nil pointers before dereference

[alrs]

Several of the functions in pkg/validation/internal properly check to make sure that they haven't received a nil pointer, but they imporperly do it only after first attempting to dereference the pointer.

[Copilot]

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR prevents potential panics when validating bundles by avoiding dereferencing bundle.Name before confirming bundle is non-nil.

Changes:

• Initialize errors.ManifestResult without using bundle.Name upfront in multiple validators
• Assign result.Name only after the bundle == nil guard

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
pkg/validation/internal/operatorhubv2.go	Avoids nil deref by setting result.Name after the nil check
pkg/validation/internal/operatorhub.go	Avoids nil deref by setting result.Name after the nil check
pkg/validation/internal/community.go	Avoids nil deref by setting result.Name after the nil check

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[perdasilva]

/ok-to-test

[perdasilva]

@grokspawn it would be good if you could 👀 this. I don't know if there was a reason to set the name in the result.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 22.16%. Comparing base (3acdcf5) to head (4b5f809).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
+ Coverage   22.13%   22.16%   +0.02%     
==========================================
  Files          60       60              
  Lines        7869     7872       +3     
==========================================
+ Hits         1742     1745       +3     
  Misses       5969     5969              
  Partials      158      158              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[tmshort]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [tmshort]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment