Add a configuration option to provide a custom logout URL for SAML2 authentication. - #3120
Open
drgrice1 wants to merge 1 commit into
Open
Add a configuration option to provide a custom logout URL for SAML2 authentication.#3120drgrice1 wants to merge 1 commit into
drgrice1 wants to merge 1 commit into
Conversation
…uthentication.
If a SAML2 identity provider does not provide a logout URL in its
metadata, and yet one is available for the identity provider, then the
`$saml2{sp}{logout_url}` option can be set to that logout URL, and it
will be used instead of the logout URL from the metadata.
This was requested in issue openwebwork#3102.
drgrice1
force-pushed
the
saml2-custom-logout-url
branch
from
August 6, 2026 22:36
aa53c2a to
d6888e4
Compare
somiaj
approved these changes
Aug 6, 2026
somiaj
left a comment
somiaj
left a comment
Contributor
There was a problem hiding this comment.
Code looks good. Unable to test.
Member
Author
|
To be honest, I can't really test it either. My local saml2 test instance provides the logout URL, and so does the provided docker test instance in the repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a SAML2 identity provider does not provide a logout URL in its metadata, and yet one is available for the identity provider, then the
$saml2{sp}{logout_url}option can be set to that logout URL, and it will be used instead of the logout URL from the metadata.This was requested in issue #3102.