Properly scope the .sortable-ghost style for the problem set detail page.#2945
Merged
dlglin merged 1 commit intoopenwebwork:WeBWorK-2.21from Apr 21, 2026
Merged
Conversation
… page. Currently that style is defined in the `system.scss` and is not scoped. As a result it applies to most content generator pages of webwork2. In particular it applies to problem pages, and thus it affects draggable proof problems which use the same sortablejs library with that same css class. Note that a related pull request to PG will change the styles for drag and drop problems and this conflicts with that. This is probably already a problem because the opacity of 0.5 does make the drag and drop elements in problems lack sufficient contrast. Although it only occurs during a mouse drag and in that situation perhaps that contrast is not necessary. Still I think there is a better way to do this for problems. On a related note to the PG pull request, perhaps at some point keyboard support should be added for reorganizing problems on the problem set detail page.
somiaj
approved these changes
Apr 21, 2026
dlglin
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently that style is defined in the
system.scssand is not scoped. As a result it applies to most content generator pages of webwork2. In particular it applies to problem pages, and thus it affects draggable proof problems which use the same sortablejs library with that same css class.Note that a related pull request to PG will change the styles for drag and drop problems and this conflicts with that. This is probably already a problem because the opacity of 0.5 does make the drag and drop elements in problems lack sufficient contrast. Although it only occurs during a mouse drag and in that situation perhaps that contrast is not necessary. Still I think there is a better way to do this for problems.
On a related note to the PG pull request, perhaps at some point keyboard support should be added for reorganizing problems on the problem set detail page.