Tool Parser for Muse Spark by przepeck · Pull Request #4441 · openvinotoolkit/model_server

przepeck · 2026-08-10T13:13:41Z

🛠 Summary

CVS-189675
New tool parser for Meta/MuseSpark

🧪 Checklist

Unit tests added.
The documentation updated.
Change follows security best practices.
``

Resolved 5 conflicts: - versions.mk: kept onyx patch-required OV_SOURCE/OV_GENAI pins; advanced OV_TOKENIZERS to the newer upstream commit (safe: tokenizers built separately with BUILD_TOKENIZERS=OFF). - src/llm/BUILD, output_parser.cpp, parser_config_validation.cpp, chat_template_end_to_end_jinja_test.cpp: additive unions keeping both the onyx parsers/tests and the incoming lfm2.5 / minicpm5 parsers/tests. Unified onyx_tool_parser onto the shared helpers introduced by the incoming branch: dropped its private parseToolSchema / createToolsParametersTypesMap (now in base_output_parser) and trimNewline / jsonTypeOf / enforceStringValue (now in io_processing/utils), which otherwise collided as static-follows-extern redeclarations. Builds clean: bazel build //src:ovms //src:ovms_test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

[Integration branch] changed install deps script to use private repos

[Integration branch] Merging parser into Integration branch

…aming Lookup content streaming

…ssor

Copilot

Pull request overview

Adds Onyx/MuseSpark tool-call and reasoning parsing with ATEM framing, template detection, streaming support, and tests.

Changes:

Adds Onyx tool and reasoning parsers.
Adds Onyx chat templates and automatic detection.
Adds parser, template, streaming, and round-trip tests.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
`src/llm/io_processing/onyx/onyx_tool_parser.hpp`	Declares Onyx tool parsing.
`src/llm/io_processing/onyx/onyx_tool_parser.cpp`	Implements ATEM parsing and streaming.
`src/llm/io_processing/onyx/onyx_reasoning_parser.hpp`	Declares reasoning parsing.
`src/llm/io_processing/onyx/onyx_reasoning_parser.cpp`	Implements reasoning extraction.
`src/llm/io_processing/output_parser.hpp`	Adds special-token decoding state.
`src/llm/io_processing/output_parser.cpp`	Integrates Onyx parsers.
`src/llm/io_processing/parser_config_validation.cpp`	Registers Onyx parser names.
`src/llm/io_processing/chat_template/analyzer.cpp`	Detects Onyx templates.
`src/llm/io_processing/chat_template/probe.cpp`	Recognizes ATEM parameters.
`src/llm/BUILD`	Adds Onyx parser targets.
`src/BUILD`	Adds round-trip test dependencies.
`extras/chat_template_examples/chat_template_onyx.jinja`	Adds example Onyx template.
`src/test/llm/chat_templates/chat_template_onyx.jinja`	Adds Onyx test template.
`src/test/llm/output_parsers/onyx_output_parser_test.cpp`	Tests parser behavior and streaming.
`src/test/llm/chat_template_and_parser_onyx_roundtrip_test.cpp`	Tests template/parser round trips.
`src/test/llm/chat_template_end_to_end_minja_test.cpp`	Adds Minja template tests.
`src/test/llm/chat_template_end_to_end_jinja_test.cpp`	Adds Jinja template tests.
`src/test/llm/chat_template_analyzer_test.cpp`	Tests Onyx detection.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

przepeck · 2026-08-11T06:45:08Z

+    if (paramIt != this->toolsParametersTypeMap.end()) {
+        auto paramJt = paramIt->second.find(currentParameterName);
+        if (paramJt != paramIt->second.end() && (paramJt->second == ParameterType::BOOLEAN)) {
+            std::transform(parameterValueAsString.begin(), parameterValueAsString.end(), parameterValueAsString.begin(), ::tolower);


@mzegla what do you think?

Sounds good, especially if we already have a function used in another parser

mzegla

Since we have confirmations about this implementation working in demos and getting good accuracy results I approve this - but note the comments. We should plan addressing any doubtful parts as soon as possible.

mzegla · 2026-08-11T13:56:59Z

+    // TODO @atobiszei we need to stream between recipient=self & <eom>
+    // TODO: streaming support is a first draft. It only forwards the chunk as
+    // reasoning_content once we've seen the "to=self" start tag; stripping the
+    // generic final-answer envelope (Case 3 above) in streaming mode is not
+    // implemented yet and needs its own design (the envelope prefix/suffix can
+    // straddle multiple chunks).


Are those TODOs resolved? If so, we should remove it, otherwise, let's plan addressing them.

mzegla · 2026-08-11T14:06:27Z

+    if (paramIt != this->toolsParametersTypeMap.end()) {
+        auto paramJt = paramIt->second.find(currentParameterName);
+        if (paramJt != paramIt->second.end() && (paramJt->second == ParameterType::BOOLEAN)) {
+            std::transform(parameterValueAsString.begin(), parameterValueAsString.end(), parameterValueAsString.begin(), ::tolower);


Sounds good, especially if we already have a function used in another parser

atobiszei and others added 30 commits July 27, 2026 16:55

Model enablement WIP

4d9b424

Build files

a558770

Experimenting with decode special tokens

1cedf23

WIP rewritten tool_parser

69aa215

changed install deps to use private repos

d6e0b58

Logging

7b10dab

patch with input applied

ec97757

Fix reasoning parser

e907e74

BFCL to check

296a91c

Merge branch 'main' into atobisze_onyx_parsers_updated

4813123

Model enablement WIP

fc10076

Build files

6e4dded

Experimenting with decode special tokens

7ef6cea

Merge branch 'muse_onyx' into atobisze_onyx_parsers_updated

1978d0a

force tokenizer master

3ea71a8

review

daabced

Merge branch 'muse_onyx' into install_deps

9544e55

Model enablement WIP

e8780bf

Build files

af40fa5

Experimenting with decode special tokens

64fdeec

Merge branch 'muse_onyx' into install_deps

2f77ce2

Merge pull request #3 from intel-sandbox/install_deps

0c26751

[Integration branch] changed install deps script to use private repos

Merge pull request #2 from intel-sandbox/atobisze_onyx_parsers_updated

9a95e8e

[Integration branch] Merging parser into Integration branch

rebase error fixed

4ce873f

rebase error fixed v2

f518ab9

rebase error fixed v3

ec5d871

remove patch application

81d9577

rebase error fix v4

4174ad9

rebase error fix v5

ca285d6

przepeck added 12 commits August 4, 2026 08:19

rebase error fix v6

8500613

update test

4330f91

lookup tokens

88ae901

flow simplification

c2d3892

remove <|start|>assistant from content

72bfdec

potential fix for to=<toolname><|message|> content

6057e68

copilot's review

bb0a408

Merge pull request #5 from intel-sandbox/przepeck/lookup_content_stre…

aa5bd8e

…aming Lookup content streaming

outdated comments, code review, revert in content normalization proce…

39ea1b7

…ssor

revert build workarounds

1ccaafd

remove outdated comment

6d75d64

revert stringOverlap parameter, tests fixed

355ab7b

przepeck requested review from dtrawins and mzegla and a balanced review from Copilot August 10, 2026 13:13

Copilot started reviewing on behalf of przepeck August 10, 2026 13:14 View session

Copilot AI reviewed Aug 10, 2026

View reviewed changes

dtrawins and others added 7 commits August 10, 2026 18:12

Merge remote-tracking branch 'origin/main' into muse_onyx

5bbc4a9

spelling

2c9c95d

style

889c750

style

87cfc7e

update test

1409a83

exception for special tags in tool parsing

0b138eb

remove comment

2e9367a

mzegla approved these changes Aug 11, 2026

View reviewed changes

dtrawins approved these changes Aug 11, 2026

View reviewed changes

dtrawins merged commit 9be7564 into main Aug 11, 2026
1 check passed

Navigation Menu

Uh oh!

Tool Parser for Muse Spark - #4441

Tool Parser for Muse Spark #4441
dtrawins merged 49 commits into
mainfrom
muse_onyx

przepeck commented Aug 10, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

przepeck Aug 11, 2026

Uh oh!

mzegla Aug 11, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mzegla left a comment

Uh oh!

mzegla Aug 11, 2026

Uh oh!

Uh oh!

mzegla Aug 11, 2026

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

przepeck commented Aug 10, 2026

🛠 Summary

🧪 Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

przepeck Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

mzegla Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mzegla left a comment

Choose a reason for hiding this comment

Uh oh!

mzegla Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mzegla Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants