Fix insecure toolchain download in build.yml - #160
Merged
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
Remove the --no-check-certificate flag from wget when fetching the GNU ARM toolchain tarball in the GitHub Actions workflow. Disabling TLS certificate verification exposed the CI pipeline to potential machine-in-the-middle (MITM) attacks where an adversary could substitute a malicious toolchain. This change re-enables TLS certificate validation and adds cryptographic checksum pinning by verifying the SHA-256 hash (bcd840f839d5bf49279638e9f67890b2ef3a7c9c7a9b25271e83ec4ff41d177a) of gcc-arm.tar.bz2 prior to extraction.
jwhui
force-pushed
the
fix_buganizer_issue_528819441
branch
from
July 28, 2026 15:47
2565a26 to
a9b642e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the --no-check-certificate flag from wget when fetching the GNU ARM toolchain tarball in the GitHub Actions workflow. Disabling TLS certificate verification exposed the CI pipeline to potential machine-in-the-middle (MITM) attacks where an adversary could substitute a malicious toolchain.
This change re-enables TLS certificate validation and adds cryptographic checksum pinning by verifying the SHA-256 hash (bcd840f839d5bf49279638e9f67890b2ef3a7c9c7a9b25271e83ec4ff41d177a) of gcc-arm.tar.bz2 prior to extraction.