fix eco test with two deprecated variables#2762
Conversation
eco-tests changed — indexer review requiredThis PR modifies files under Changed files
|
🛡️ AI Review — Skeptic (security review)VERDICT: SAFE LOW scrutiny: open-junius has write permission and substantial prior activity; branch fix-eco-test -> devnet-ready. FindingsNo findings. ConclusionNo malicious behavior or security vulnerability is apparent from this four-line test-only deletion. The change does not alter runtime logic, dependencies, workflows, or trusted review-instruction paths, and there are no prior Skeptic findings to carry forward. 🔍 AI Review — Auditor (domain review)VERDICT: 👍 Gittensor: LIKELY; open-junius has repo write permission, substantial prior GitHub/subtensor activity, and no allowlist hit. The Auditor proposed a replacement PR description, but the current body is non-trivial; not overwriting. Maintainers: ask the Auditor to regenerate if you want it. Static review only. The PR deletes four eco-test lines that referenced deprecated swap storage items; those names now only appear under swap migration aliases/tests, so removing them from the live indexer compile checks is consistent. No runtime code changed, so no FindingsNo findings. ConclusionApprove: this is a narrowly scoped test-maintenance fix with no runtime, economic, storage, origin, migration, dependency, or workflow impact. I found no domain issues to block merge. |
|
🔄 AI review updated — Skeptic: SAFE Auditor: 👍 |
Description
There are two storage AlphaSqrtPrice and EnabledUserLiquidity deprecated, remove them from eco test.
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.