Skip to content

fix eco test with two deprecated variables#2762

Open
open-junius wants to merge 1 commit into
devnet-readyfrom
fix-eco-test
Open

fix eco test with two deprecated variables#2762
open-junius wants to merge 1 commit into
devnet-readyfrom
fix-eco-test

Conversation

@open-junius

Copy link
Copy Markdown
Contributor

Description

There are two storage AlphaSqrtPrice and EnabledUserLiquidity deprecated, remove them from eco test.

Related Issue(s)

  • Closes #[issue number]

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@open-junius open-junius self-assigned this Jun 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

eco-tests changed — indexer review required

This PR modifies files under eco-tests/. and may affect downstream indexing.
cc @evgeny-s — please review manually

Changed files
  • eco-tests/src/tests_taocom_indexer.rs

@github-actions github-actions Bot requested a review from evgeny-s June 17, 2026 03:32
@github-actions

github-actions Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

LOW scrutiny: open-junius has write permission and substantial prior activity; branch fix-eco-test -> devnet-ready.

Findings

No findings.

Conclusion

No malicious behavior or security vulnerability is apparent from this four-line test-only deletion. The change does not alter runtime logic, dependencies, workflows, or trusted review-instruction paths, and there are no prior Skeptic findings to carry forward.


🔍 AI Review — Auditor (domain review)

VERDICT: 👍

Gittensor: LIKELY; open-junius has repo write permission, substantial prior GitHub/subtensor activity, and no allowlist hit.

The Auditor proposed a replacement PR description, but the current body is non-trivial; not overwriting. Maintainers: ask the Auditor to regenerate if you want it.

Static review only. The PR deletes four eco-test lines that referenced deprecated swap storage items; those names now only appear under swap migration aliases/tests, so removing them from the live indexer compile checks is consistent. No runtime code changed, so no spec_version bump is required. No overlapping PRs were reported, and no auto-fixes were needed.

Findings

No findings.

Conclusion

Approve: this is a narrowly scoped test-maintenance fix with no runtime, economic, storage, origin, migration, dependency, or workflow impact. I found no domain issues to block merge.

@github-actions

Copy link
Copy Markdown
Contributor

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

@open-junius open-junius added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Jun 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant