[18-stable] Validate PasswordSecret namespace matches OpenStackBaremetalSet namespace - #433
Merged
openshift-merge-bot[bot] merged 1 commit intoJul 29, 2026
Conversation
…pace The PasswordSecret field (corev1.SecretReference) was not validated to restrict its namespace. This could allow a user to reference a secret in an arbitrary namespace and have the operator read it on their behalf. Add validation that PasswordSecret must be in the OpenStackBaremetalSet's own namespace (where the user already has RBAC access), since this secret is only consumed by this operator and not passed to Metal3 directly. Also enforce secret namespace validation on update (previously only on create). Signed-off-by: rabi <ramishra@redhat.com>
rabi
approved these changes
Jul 29, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, rabi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit Jul 29, 2026
3b64c2f
into
openstack-k8s-operators:18-stable
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #422
/assign rabi