Skip to content

Remove unnecessary pods RBAC permissions - #423

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
stuggi:rbac-cleanup-pods
Jul 25, 2026
Merged

Remove unnecessary pods RBAC permissions#423
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
stuggi:rbac-cleanup-pods

Conversation

@stuggi

@stuggi stuggi commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

The workload rbacRules and a kubebuilder RBAC marker granted full CRUD (create/delete/get/list/patch/update/watch) on core Pods, which was never exercised. Remove the unused permission and regenerate config/rbac/role.yaml.

The narrower get;list;update;watch;patch marker is kept, since the controller lists and updates provision server Pods directly.

The workload rbacRules and a kubebuilder RBAC marker granted full CRUD
(create/delete/get/list/patch/update/watch) on core Pods, which was never
exercised. Remove the unused permission and regenerate config/rbac/role.yaml.

The narrower get;list;update;watch;patch marker is kept, since the
controller lists and updates provision server Pods directly.

Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
@openshift-ci
openshift-ci Bot requested review from dprince and rabi July 24, 2026 14:04
@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/7f4d1bc2933144dfb8f6f7fa801319ca

openstack-baremetal-operator-content-provider FAILURE in 13m 58s
⚠️ openstack-baremetal-operator-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-baremetal-operator-content-provider
⚠️ openstack-baremetal-operator-edpm-baremetal-minor-update SKIPPED Skipped due to failed job openstack-baremetal-operator-content-provider

@stuggi

stuggi commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

recheck

@stuggi

stuggi commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

/retest

@abays abays left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, stuggi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the lgtm label Jul 24, 2026
@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/4d608e38a6514dcdacc33a5ea6b0b3ae

✔️ openstack-baremetal-operator-content-provider SUCCESS in 3h 10m 59s
openstack-baremetal-operator-crc-podified-edpm-baremetal FAILURE in 1h 26m 12s
✔️ openstack-baremetal-operator-edpm-baremetal-minor-update SUCCESS in 2h 26m 49s

@stuggi

stuggi commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

recheck

@openshift-merge-bot
openshift-merge-bot Bot merged commit cd4e3c9 into openstack-k8s-operators:main Jul 25, 2026
7 checks passed
@stuggi

stuggi commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

/cherry-pick 18-stable

@openshift-cherrypick-robot

Copy link
Copy Markdown

@stuggi: new pull request created: #432

Details

In response to this:

/cherry-pick 18-stable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants