Sanitize error details from CR status conditions - #35
Open
umago wants to merge 1 commit into
Open
Conversation
Flagged by ESS SEC-APP-REQ-1 assessment for input/output validation/sanitization. The raw err.Error() output in status conditions was visible to anyone with kubectl describe access, potentially leaking Kubernetes API error details, internal service names, and secret names. Replace with a generic message and log the full error to the operator logs instead, where access is controlled. Signed-off-by: Lucas Alvares Gomes <lucasagomes@gmail.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: umago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flagged by ESS SEC-APP-REQ-1 assessment for input/output validation/sanitization.
The raw err.Error() output in status conditions was visible to anyone with kubectl describe access, potentially leaking Kubernetes API error details, internal service names, and secret names.
Replace with a generic message and log the full error to the operator logs instead, where access is controlled.