Add tests for cinderBackups in dz-storage scenario#3927
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @gais-ameer-rh. Thanks for your PR. I'm waiting for a openstack-k8s-operators member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 27m 53s |
To deploy multiple cinder backups based on AZ topology Removes the existing spec.cinder.template.cinderBackup (singluar) and replaces with cinderBackups (plural) Depends-On: openstack-k8s-operators/ci-framework#3927 OSPRH-28342
spec.cinder.template.cinderBackup (singluar) in DZ-Storage DT is replaced with cinderBackups (plural) to deploy multiple cinder backups based on AZ topology. hooks/playbooks/dz_storage_cinder_backups.yaml validates the behaviour of cinderBackups. The playbook tests different scenarios of cinder backup creation and restoring the backups across availability zones. Jira: OSPRH-28342 Signed-off-by: Gais Ameer <gameer@redhat.com> Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
gais-ameer-rh
force-pushed
the
cinderBackups
branch
from
1c8d775 to
bb02fb1
Compare
|
recheck |
fultonj
left a comment
fultonj
left a comment
There was a problem hiding this comment.
Thanks Gais! A few suggestions.
| failed_when: "'az1' not in vol_az1_restore_az1_zone.stdout" | ||
|
|
||
| # ================================================================================== | ||
| # Cleanup before Scenario 2 |
There was a problem hiding this comment.
Please remove lines 121-150. It will save CI Time.
I assume the clean up was done so names could be re-used in the subsequent scenario, but please use a different name instead.
| # 1. AZ1 backs up to AZ1 and restores to AZ1 | ||
| # 2. AZ1 backs up to AZ2 and restores to AZ1 | ||
| # 3. AZ1 backs up to AZ2 and restores to AZ2 | ||
|
|
There was a problem hiding this comment.
Please try setting the environment on the play level instead of per task. That should make the playbook shorter. For example...
- name: Test Cinder backup and restore across availability zones
hosts: "{{ cifmw_target_host | default('localhost') }}"
environment:
KUBECONFIG: "{{ cifmw_openshift_kubeconfig | default('/home/' + ansible_user | default('zuul') + '/.kube/config') }}"
PATH: "{{ cifmw_path | default(ansible_env.PATH) }}"
tasks:
# Scenario 1: AZ1 backs up to AZ1 and restores to AZ1
- name: "Scenario 1: Create volume in AZ1"
ansible.builtin.command: >-
oc rsh
-n {{ cifmw_openstack_namespace }}
openstackclient
openstack volume create --size 1 vol-az1 --availability-zone az1 -f value -c id
register: vol_az1_id2 participants
[DZ-Storage] Add tests for cinderBackups
spec.cinder.template.cinderBackup (singluar) in DZ-Storage DT is
replaced with cinderBackups (plural) to deploy multiple cinder backups based on AZ topology.
hooks/playbooks/dz_storage_cinder_backups.yaml validates the behaviour of cinderBackups.
The playbook tests different scenarios of cinder backup creation
and restoring the backups across availability zones.
Jira: OSPRH-28342
Signed-off-by: Gais Ameer gameer@redhat.com
Co-Authored-By: Claude Sonnet 4.5 noreply@anthropic.com