Skip to content

[libvirt_manager] Add predictable network interface names to EDPM#3891

Merged
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
holser:feat_pnin
May 15, 2026
Merged

[libvirt_manager] Add predictable network interface names to EDPM#3891
openshift-merge-bot[bot] merged 1 commit into
openstack-k8s-operators:mainfrom
holser:feat_pnin

Conversation

@holser
Copy link
Copy Markdown
Contributor

@holser holser commented Apr 24, 2026 •
edited
Loading

Enable systemd predictable network interface naming inside guest VMs
by removing net.ifnames=0 from kernel args via virt-customize. This
gives guests consistent PCI-topology-based names (enp1s0, enp2s0, etc.)
instead of legacy ethN naming. Predictable network interfaces are
requirement for testing Leapp upgrade functionality.

Controlled by cifmw_libvirt_manager_predictable_nic_names (defaults
to false).

Jira: OSPRH-29381

@evallesp
Copy link
Copy Markdown
Contributor

evallesp commented Apr 27, 2026

LGTM, asked for a TP.

@danpawlik danpawlik requested a review from a team April 28, 2026 06:05
nemarjan
nemarjan reviewed Apr 28, 2026
View reviewed changes
Comment thread roles/libvirt_manager/tasks/attach_interface.yml Outdated
@centosinfra-prod-github-app
Copy link
Copy Markdown

centosinfra-prod-github-app Bot commented May 5, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/3f0056fc5ff24f52859aae04918357d6

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 19m 14s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 22m 38s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 25m 34s
✔️ cifmw-crc-podified-edpm-baremetal-minor-update SUCCESS in 2h 06m 39s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 35s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 13s
❌ cifmw-pod-pre-commit FAILURE in 8m 41s
✔️ cifmw-molecule-libvirt_manager SUCCESS in 46m 11s
✔️ cifmw-molecule-reproducer SUCCESS in 14m 21s

@holser @xbezdick @claude
[libvirt_manager] Add predictable interface names
3cc6283 
Enable systemd predictable network interface naming inside guest VMs
by removing net.ifnames=0 from kernel args via virt-customize. This
gives guests consistent PCI-topology-based names (enp1s0, enp2s0, etc.)
instead of legacy ethN naming. Predictable network interfaces are
requirement for testing Leapp upgrade functionality.

Controlled by cifmw_libvirt_manager_predictable_nic_names (defaults
to false).

Jira: OSPRH-29381

Co-Authored-By: Lukas Bezdicka <lbezdick@redhat.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Sergii Golovatiuk <sgolovat@redhat.com>
@nemarjan nemarjan requested a review from evallesp May 6, 2026 13:48
@nemarjan
Copy link
Copy Markdown
Contributor

nemarjan commented May 6, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label May 6, 2026
@holser holser changed the title [libvirt_manager] Add predictable network interface names via --target [libvirt_manager] Add predictable network interface names to EDPM May 8, 2026
@nemarjan nemarjan requested a review from Valkyrie00 May 8, 2026 13:58
@michburk
Copy link
Copy Markdown
Contributor

michburk commented May 12, 2026

Changes lgtm, especially seeing that they are opt-in, but @holser do you have a testproject that uses these changes that you could link in the comments of that jira story? I see Enrique requested one here and in the jira comments.

@holser
Copy link
Copy Markdown
Contributor Author

holser commented May 14, 2026

Changes lgtm, especially seeing that they are opt-in, but @holser do you have a testproject that uses these changes that you could link in the comments of that jira story? I see Enrique requested one here and in the jira comments.

Sorry. I was PTO for a while. I have created test project to test the changes.

@holser holser requested a review from michburk May 15, 2026 07:44
@evallesp
Copy link
Copy Markdown
Contributor

evallesp commented May 15, 2026

Got TP. merging

evallesp
evallesp approved these changes May 15, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@evallesp evallesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@holser holser requested review from rebtoor and removed request for Valkyrie00 May 15, 2026 08:15
@xbezdick
Copy link
Copy Markdown
Contributor

xbezdick commented May 15, 2026

/lgtm
/approve

@nemarjan
Copy link
Copy Markdown
Contributor

nemarjan commented May 15, 2026

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 15, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: evallesp, nemarjan, xbezdick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit a6fadbb into openstack-k8s-operators:main May 15, 2026
21 checks passed
@holser holser requested a review from xbezdick May 15, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nemarjan nemarjan nemarjan left review comments

@evallesp evallesp evallesp approved these changes

@michburk michburk Awaiting requested review from michburk

@rebtoor rebtoor Awaiting requested review from rebtoor

@xbezdick xbezdick Awaiting requested review from xbezdick

Assignees

@xbezdick xbezdick

@nemarjan nemarjan

Labels

approved lgtm Ready For Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@holser @evallesp @nemarjan @michburk @xbezdick