feat(oauth2): Add secondary indexes to raft driver - #1327
Merged
Merged
Conversation
Refresh token revocation and expiry sweeps were full scans: nothing mapped a user/client/domain to its refresh families, and no index ordered records by expires_at. Add refresh_user_idx, refresh_client_idx, refresh_domain_idx and expiry_idx, written atomically with their primary record via StorageApi::transaction, plus the corresponding list_refresh_families_by_* and list_expired backend methods. Closes: #1255 Signed-off-by: artem.goncharov <artem.goncharov@gmail.com>
gtema
enabled auto-merge
September 19, 2026 07:22
|
🧪 Tempest Identity Compatibility Results (advisory, non-blocking) rust Failed test IDs |
|
🦢 Load Test Results Goose Attack ReportPlan Overview
Request Metrics
Response Time Metrics
Status Code Metrics
Transaction Metrics
Scenario Metrics
Error Metrics
|
|
Bencher Report| Project | keystone |
| Branch | issue_1255 |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| Command_Serde/apply/remove | 📈 view plot 🚷 view threshold | 145,450.00 ns(-50.00%)Baseline: 290,921.48 ns | 1,448,360.30 ns (10.04%) |
| Command_Serde/apply/set | 📈 view plot 🚷 view threshold | 163,230.00 ns(-64.52%)Baseline: 460,034.50 ns | 3,320,932.43 ns (4.92%) |
| Command_Serde/pack/delete | 📈 view plot 🚷 view threshold | 129.21 ns(+11.16%)Baseline: 116.23 ns | 158.28 ns (81.63%) |
| Command_Serde/pack/delete_index | 📈 view plot 🚷 view threshold | 114.40 ns(+10.46%)Baseline: 103.57 ns | 139.50 ns (82.01%) |
| Command_Serde/pack/set | 📈 view plot 🚷 view threshold | 216.64 ns(+14.64%)Baseline: 188.97 ns | 252.07 ns (85.95%) |
| Command_Serde/pack/set_index | 📈 view plot 🚷 view threshold | 113.89 ns(+9.98%)Baseline: 103.55 ns | 140.01 ns (81.35%) |
| Command_Serde/unpack/delete | 📈 view plot 🚷 view threshold | 187.79 ns(+2.44%)Baseline: 183.32 ns | 271.91 ns (69.06%) |
| Command_Serde/unpack/delete_index | 📈 view plot 🚷 view threshold | 161.33 ns(+5.50%)Baseline: 152.92 ns | 221.14 ns (72.95%) |
| Command_Serde/unpack/set | 📈 view plot 🚷 view threshold | 300.04 ns(+14.62%)Baseline: 261.77 ns | 375.08 ns (79.99%) |
| Command_Serde/unpack/set_index | 📈 view plot 🚷 view threshold | 155.73 ns(+3.32%)Baseline: 150.73 ns | 215.98 ns (72.10%) |
| Payload_encryption/pack/remove_cmd | 📈 view plot 🚷 view threshold | 119.72 ns(+9.40%)Baseline: 109.43 ns | 152.34 ns (78.59%) |
| Payload_encryption/pack/set_cmd | 📈 view plot 🚷 view threshold | 196.86 ns(-0.65%)Baseline: 198.16 ns | 274.59 ns (71.69%) |
| Payload_encryption/unpack/remove_cmd | 📈 view plot 🚷 view threshold | 209.97 ns(+9.60%)Baseline: 191.57 ns | 285.30 ns (73.60%) |
| Payload_encryption/unpack/set_cmd | 📈 view plot 🚷 view threshold | 300.27 ns(+11.07%)Baseline: 270.35 ns | 390.24 ns (76.95%) |
| Raft_1Node_Latency/prefix/1node | 📈 view plot 🚷 view threshold | 3,713,500.00 ns(+19.84%)Baseline: 3,098,655.45 ns | 8,535,779.00 ns (43.51%) |
| Raft_1Node_Latency/read/1node | 📈 view plot 🚷 view threshold | 43,825.00 ns(+17.93%)Baseline: 37,163.17 ns | 52,924.41 ns (82.81%) |
| Raft_1Node_Latency/remove/1node | 📈 view plot 🚷 view threshold | 423,320.00 ns(-65.27%)Baseline: 1,219,026.72 ns | 11,551,591.25 ns (3.66%) |
| Raft_1Node_Latency/write/1node | 📈 view plot 🚷 view threshold | 447,890.00 ns(-55.11%)Baseline: 997,660.00 ns | 7,587,427.38 ns (5.90%) |
| build_snapshot/default | 📈 view plot 🚷 view threshold | 115,440.00 ns(-5.34%)Baseline: 121,957.52 ns | 267,204.80 ns (43.20%) |
| fernet token/project | 📈 view plot 🚷 view threshold | 1,444.30 ns(+3.49%)Baseline: 1,395.58 ns | 1,831.34 ns (78.87%) |
| get_data_keyspace | 📈 view plot 🚷 view threshold | 0.31 ns(+0.61%)Baseline: 0.31 ns | 0.39 ns (79.98%) |
| get_db | 📈 view plot 🚷 view threshold | 0.31 ns(+0.55%)Baseline: 0.31 ns | 0.39 ns (79.91%) |
| get_fernet_token_timestamp/project | 📈 view plot 🚷 view threshold | 152.86 ns(+10.38%)Baseline: 138.48 ns | 184.29 ns (82.94%) |
| get_keyspace | 📈 view plot 🚷 view threshold | 4.46 ns(-23.25%)Baseline: 5.81 ns | 12.70 ns (35.09%) |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refresh token revocation and expiry sweeps were full scans: nothing
mapped a user/client/domain to its refresh families, and no index
ordered records by expires_at. Add refresh_user_idx,
refresh_client_idx, refresh_domain_idx and expiry_idx, written
atomically with their primary record via StorageApi::transaction,
plus the corresponding list_refresh_families_by_* and list_expired
backend methods.
Closes: #1255
Signed-off-by: artem.goncharov artem.goncharov@gmail.com