Conversation
ConfigManager.spawn_watch_loop() uses a biased select! with sync_rx.recv() before shutdown.cancelled(). When parallel config tests create temp files in sibling parent directories, inotify fires cross-directory modification events that queue into sync_rx. Each event triggers a 500ms debounce sleep, and the biased select! delays shutdown or renewal indefinitely. Change both tests to #[serial] to isolate their notify watchers from other config tests. Add sleep(100ms) after ConfigManager.watched() so the spawned task has multiple scheduling chances to enter its select! and arm the vault_tick deadline. Wrap shutdown() in a timeout to fail fast if the task still hangs. Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
gtema
enabled auto-merge
July 28, 2026 13:23
|
🦢 Load Test Results Goose Attack ReportPlan Overview
Request Metrics
Response Time Metrics
Status Code Metrics
Transaction Metrics
Scenario Metrics
|
|
🧪 Tempest Identity Compatibility Results (advisory, non-blocking) rust Failed test IDs |
Open
|
Bencher Report| Project | keystone |
| Branch | flaky |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| Command_Serde/apply/remove | 📈 view plot 🚷 view threshold | 97,115.00 ns(-68.50%)Baseline: 308,263.34 ns | 1,597,799.48 ns (6.08%) |
| Command_Serde/apply/set | 📈 view plot 🚷 view threshold | 97,184.00 ns(-70.46%)Baseline: 328,976.91 ns | 1,575,959.92 ns (6.17%) |
| Command_Serde/pack/delete | 📈 view plot 🚷 view threshold | 126.75 ns(+6.92%)Baseline: 118.54 ns | 155.79 ns (81.36%) |
| Command_Serde/pack/delete_index | 📈 view plot 🚷 view threshold | 114.34 ns(+9.07%)Baseline: 104.83 ns | 136.39 ns (83.83%) |
| Command_Serde/pack/set | 📈 view plot 🚷 view threshold | 193.75 ns(+2.04%)Baseline: 189.88 ns | 247.71 ns (78.22%) |
| Command_Serde/pack/set_index | 📈 view plot 🚷 view threshold | 114.72 ns(+9.46%)Baseline: 104.80 ns | 136.52 ns (84.03%) |
| Command_Serde/unpack/delete | 📈 view plot 🚷 view threshold | 221.21 ns(+19.55%)Baseline: 185.03 ns | 264.20 ns (83.73%) |
| Command_Serde/unpack/delete_index | 📈 view plot 🚷 view threshold | 179.73 ns(+15.92%)Baseline: 155.04 ns | 215.66 ns (83.34%) |
| Command_Serde/unpack/set | 📈 view plot 🚷 view threshold | 288.66 ns(+11.37%)Baseline: 259.18 ns | 352.25 ns (81.95%) |
| Command_Serde/unpack/set_index | 📈 view plot 🚷 view threshold | 174.71 ns(+14.69%)Baseline: 152.33 ns | 211.09 ns (82.77%) |
| Payload_encryption/pack/remove_cmd | 📈 view plot 🚷 view threshold | 117.54 ns(+5.00%)Baseline: 111.94 ns | 147.98 ns (79.43%) |
| Payload_encryption/pack/set_cmd | 📈 view plot 🚷 view threshold | 189.99 ns(-2.86%)Baseline: 195.58 ns | 265.38 ns (71.59%) |
| Payload_encryption/unpack/remove_cmd | 📈 view plot 🚷 view threshold | 234.46 ns(+20.43%)Baseline: 194.69 ns | 279.60 ns (83.86%) |
| Payload_encryption/unpack/set_cmd | 📈 view plot 🚷 view threshold | 277.91 ns(+2.28%)Baseline: 271.72 ns | 375.59 ns (73.99%) |
| Raft_1Node_Latency/prefix/1node | 📈 view plot 🚷 view threshold | 4,289,900.00 ns(+57.62%)Baseline: 2,721,646.09 ns | 6,564,437.07 ns (65.35%) |
| Raft_1Node_Latency/read/1node | 📈 view plot 🚷 view threshold | 35,140.00 ns(-8.07%)Baseline: 38,222.69 ns | 54,116.03 ns (64.93%) |
| Raft_1Node_Latency/remove/1node | 📈 view plot 🚷 view threshold | 274,020.00 ns(-65.53%)Baseline: 794,955.62 ns | 3,891,058.86 ns (7.04%) |
| Raft_1Node_Latency/write/1node | 📈 view plot 🚷 view threshold | 286,600.00 ns(-69.77%)Baseline: 947,995.31 ns | 5,439,675.79 ns (5.27%) |
| build_snapshot/default | 📈 view plot 🚷 view threshold | 108,020.00 ns(-12.46%)Baseline: 123,400.02 ns | 208,899.32 ns (51.71%) |
| fernet token/project | 📈 view plot 🚷 view threshold | 1,572.70 ns(+11.72%)Baseline: 1,407.74 ns | 1,791.01 ns (87.81%) |
| get_data_keyspace | 📈 view plot 🚷 view threshold | 0.35 ns(+12.17%)Baseline: 0.31 ns | 0.39 ns (91.05%) |
| get_db | 📈 view plot 🚷 view threshold | 0.35 ns(+12.18%)Baseline: 0.31 ns | 0.39 ns (91.14%) |
| get_fernet_token_timestamp/project | 📈 view plot 🚷 view threshold | 150.35 ns(+7.92%)Baseline: 139.31 ns | 179.94 ns (83.55%) |
| get_keyspace | 📈 view plot 🚷 view threshold | 4.77 ns(-16.33%)Baseline: 5.70 ns | 12.89 ns (36.97%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConfigManager.spawn_watch_loop() uses a biased select! with
sync_rx.recv() before shutdown.cancelled(). When parallel config tests
create temp files in sibling parent directories, inotify fires
cross-directory modification events that queue into sync_rx. Each event
triggers a 500ms debounce sleep, and the biased select! delays shutdown
or renewal indefinitely.
Change both tests to #[serial] to isolate their notify watchers from
other config tests. Add sleep(100ms) after ConfigManager.watched() so
the spawned task has multiple scheduling chances to enter its select!
and arm the vault_tick deadline. Wrap shutdown() in a timeout to fail
fast if the task still hangs.
Signed-off-by: Artem Goncharov artem.goncharov@gmail.com