OCPBUGS-92032: Dockerfile: Copy only build-required files in builder stage

[Miciah]

Replace the broad "COPY . ." instruction in the builder stage with targeted COPY instructions for only the files and directories that "make build" requires. This excludes documentation, CI configuration, and other files that are not needed for the build, reducing the amount of data copied into the builder image.

Summary by CodeRabbit

• Chores
  • Streamlined the container build process to include only the files needed for compilation.
  • Kept the final runtime image and delivered application binary unchanged.

[openshift-ci-robot]

@Miciah: This pull request references Jira Issue OCPBUGS-92032, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Replace the broad "COPY . ." instruction in the builder stage with targeted COPY instructions for only the files and directories that "make build" requires. This excludes documentation, CI configuration, and other files that are not needed for the build, reducing the amount of data copied into the builder image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 73fce04f-0ce0-486a-8bee-85a5f58ea440

📥 Commits

Reviewing files that changed from the base of the PR and between 01ccbfb and b1e7ed8.

📒 Files selected for processing (1)

• Dockerfile

---

Walkthrough

The Dockerfile’s builder stage now copies selected build inputs explicitly instead of the full build context. The build command and final runtime stage remain unchanged.

Changes

Dockerfile builder stage update

Layer / File(s)	Summary
Explicit builder COPY Dockerfile	The builder stage replaces COPY . . with explicit copies of Makefile, go.mod, go.sum, .git, cmd/, pkg/, and vendor/.

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely describes the main Dockerfile builder-stage copy change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No Ginkgo specs use dynamic titles; the only subtests use static string-literal names like tc.name/tt.name tables.
Test Structure And Quality	✅ Passed	No Ginkgo test code was changed; the PR only updates Dockerfile copy instructions, so the test-quality check is not applicable.
Microshift Test Compatibility	✅ Passed	Only Dockerfile changed in this commit; no Ginkgo/e2e test files or test code were added or modified, so MicroShift compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR only changes Dockerfile COPY instructions; no Go/Ginkgo test files were added or modified, so SNO compatibility is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR only narrows Dockerfile COPY inputs; no deployment manifests, controllers, replicas, affinity, selectors, or topology-aware scheduling code were modified.
Ote Binary Stdout Contract	✅ Passed	PASS — the PR only changes Dockerfile COPY instructions; no process-level Go code was modified, and main/suite setup shows no stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only changes Dockerfile, .ci-operator.yaml, and go.mod; no Ginkgo e2e tests or IPv4/external-connectivity logic were added.
No-Weak-Crypto	✅ Passed	Dockerfile-only change; it just narrows COPY inputs for the builder stage and adds no weak-crypto, custom-crypto, or token-compare code.
Container-Privileges	✅ Passed	Only the Dockerfile changed; no non-vendor manifests contain privileged, hostPID/Network/IPC, allowPrivilegeEscalation, or SYS_ADMIN settings.
No-Sensitive-Data-In-Logs	✅ Passed	Only Dockerfile COPY instructions changed; no logging code or sensitive data exposure was added.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@Miciah: This pull request references Jira Issue OCPBUGS-92032, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

Details

In response to this:

Replace the broad "COPY . ." instruction in the builder stage with targeted COPY instructions for only the files and directories that "make build" requires. This excludes documentation, CI configuration, and other files that are not needed for the build, reducing the amount of data copied into the builder image.

Summary by CodeRabbit

• Chores
• Streamlined the container build process to include only the files needed for compilation.
• Kept the final runtime image and delivered application binary unchanged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[gcs278]

/assign @rhamini3

[melvinjoseph86]

/verified by CI
As the make from docker file is working fine

[openshift-ci-robot]

@melvinjoseph86: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI
As the make from docker file is working fine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rhamini3]

/retest

[openshift-ci]

@Miciah: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[rhamini3]

/lgtm
/approve

[gcs278]

approving by proxy for @rhamini3 since he is not in the owners file

I've also reviewed quickly, generally LGTM. I question whether the .git is needed for building, but I suppose it doesn't hurt much to have it.

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gcs278, Miciah, rhamini3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [Miciah,gcs278]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment