Skip to content

NE-2767: Bump Kubernetes to 1.36.2#100

Open
aswinsuryan wants to merge 1 commit into
openshift:mainfrom
aswinsuryan:NE-2767/k8s-1.36-bump
Open

NE-2767: Bump Kubernetes to 1.36.2#100
aswinsuryan wants to merge 1 commit into
openshift:mainfrom
aswinsuryan:NE-2767/k8s-1.36-bump

Conversation

@aswinsuryan

@aswinsuryan aswinsuryan commented Jul 15, 2026

Copy link
Copy Markdown
Contributor
  • Bump k8s.io modules to v0.36.2 (k8s.io/kubernetes to v1.36.2) and update OpenShift dependencies to latest
  • Fix Go 1.26 vet error for non-constant format string in Eventf call in pkg/route/ingressip/service_ingressip_controller.go

Summary by CodeRabbit

  • Bug Fixes

    • Corrected warning messages shown when a service’s ingress IP is reallocated, ensuring the event displays the message consistently.
  • Chores

    • Updated underlying Kubernetes, OpenShift, networking, observability, and supporting libraries to newer versions for improved compatibility and maintenance.

Bump k8s.io modules to v0.36.2 (k8s.io/kubernetes to v1.36.2),
and update OpenShift dependencies to latest. Fix Go 1.26 vet
error for non-constant format string in Eventf call.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Aswin Suryanarayanan <asuryana@redhat.com>
@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot

openshift-ci-robot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

@aswinsuryan: This pull request references NE-2767 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

  • Bump k8s.io modules to v0.36.2 (k8s.io/kubernetes to v1.36.2) and update OpenShift dependencies to latest
  • Fix Go 1.26 vet error for non-constant format string in Eventf call in pkg/route/ingressip/service_ingressip_controller.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 15, 2026
@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉


Walkthrough

The pull request updates direct and indirect Go dependencies, including OpenShift and Kubernetes components, and changes the ingress IP reallocation warning event to use an explicit format string.

Changes

Dependency modernization

Layer / File(s) Summary
Go module dependency updates
go.mod
Direct and indirect dependencies are advanced across OpenShift, Kubernetes, OpenAPI, gRPC, OTEL, Prometheus, and related libraries, with newer dependency replacements included.

Ingress event formatting

Layer / File(s) Summary
Reallocation event format
pkg/route/ingressip/service_ingressip_controller.go
The ingress IP reallocation warning event passes reallocateMessage through a "%s" format string.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: frobware, jcmoraisjr, rikatz


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
No-Weak-Crypto ❌ Error The dependency bump adds weak TLS cipher references (RC4/3DES/DES-CBC3-SHA) in vendor/github.com/openshift/library-go/pkg/crypto/crypto.go. Remove or justify the weak cipher-suite mappings from the vendored OpenShift crypto helper, or update to a version that excludes them.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: upgrading Kubernetes to 1.36.2.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed No test files or Ginkgo titles were changed; the PR only updates dependencies/vendor and one controller source hunk.
Test Structure And Quality ✅ Passed No Ginkgo test files were changed; the PR only updates dependencies and a non-test Eventf call.
Microshift Test Compatibility ✅ Passed No Ginkgo/e2e test files or specs were added or changed; the PR only updates deps and a controller event call.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the patch only updates dependencies and fixes an Eventf format string, with no *_test.go changes or It/Describe/Context usage.
Topology-Aware Scheduling Compatibility ✅ Passed Only go.mod/vendor updates and an Eventf format fix changed; no manifests, affinity/selectors, replicas, or topology-aware scheduling logic were introduced.
Ote Binary Stdout Contract ✅ Passed PR only bumps deps and changes one Eventf call; diff search found no added process-level stdout writes or logging redirection changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR changes only go.mod/go.sum and one controller Eventf call; no *_test.go or Ginkgo e2e tests were added.
Container-Privileges ✅ Passed No non-vendor YAML/JSON manifests changed, and the diff contains no privileged/hostPID/hostNetwork/hostIPC/allowPrivilegeEscalation/SYS_ADMIN settings.
No-Sensitive-Data-In-Logs ✅ Passed Only new event log uses generic %s and reallocateMessage is built from IP/service-key errors; no passwords/tokens/PII/etc. appear in changed first-party code.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aswinsuryan
Once this PR has been reviewed and has the lgtm label, please assign thealisyed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aswinsuryan
aswinsuryan marked this pull request as ready for review July 15, 2026 03:42
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 15, 2026
@openshift-ci
openshift-ci Bot requested review from frobware and jcmoraisjr July 15, 2026 03:43
@jcmoraisjr

Copy link
Copy Markdown
Member

/assign

@aswinsuryan

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@aswinsuryan

Copy link
Copy Markdown
Contributor Author

/retest-required

1 similar comment
@aswinsuryan

Copy link
Copy Markdown
Contributor Author

/retest-required

@openshift-ci

openshift-ci Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

@aswinsuryan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 442cd7f link true /test e2e-aws-ovn
ci/prow/e2e-gcp 442cd7f link true /test e2e-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@relda88 relda88 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approach is solid. Minor nit: this would benefit from a brief comment explaining why we skip validation for internal callers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants