Trigger e2e-aws-techpreview on OSImageStream changes for openshift/hypershift

[sdminonne]

Summary

• Add pipeline_run_if_changed to the existing e2e-aws-techpreview job so it triggers automatically when PRs touch OSImageStream-related code

Why

The OSStreams feature gate is disabled in the Default feature set, which strips spec.osImageStream from the NodePool CRD entirely. As a result:

• e2e-aws / e2e-aws-4-22 (Default feature set): OSImageStream tests skip because the field isn't in the CRD
• e2e-v2-aws (TechPreview): Uses --ginkgo.label-filter='!lifecycle' which excludes the lifecycle-labeled OSImageStream tests
• e2e-aws-techpreview: Has TechPreview enabled and runs lifecycle tests, but is manual-only (always_run: false, no run_if_changed)

No CI job currently exercises the NodePool OSImageStream e2e tests automatically.

What

Add pipeline_run_if_changed: (osimagestream|OSImageStream|os_image_stream|OSStreams) to the existing e2e-aws-techpreview job. This triggers the job automatically when PRs modify OSImageStream-related files, providing CI coverage for TechPreview-gated features.

Related

• Add e2e tests for NodePool OSImageStream (v1 and v2) hypershift#9033 — adds e2e tests for NodePool OSImageStream

🤖 Generated with Claude Code

Summary by CodeRabbit

Updates the OpenShift Hypershift repository’s e2e-aws-techpreview CI job to run when pull requests modify OSImageStream-related files, providing automated coverage for TechPreview-gated NodePool OSImageStream tests.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sdminonne
Once this PR has been reviewed and has the lgtm label, please assign bryan-cox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/hypershift/OWNERS
• ci-operator/jobs/openshift/hypershift/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 9a9d852f-8a3f-441a-8f27-218bf4c24c14

📥 Commits

Reviewing files that changed from the base of the PR and between 89c0935 and 588fb3f.

⛔ Files ignored due to path filters (1)

• ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-presubmits.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (1)

• ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml

---

Walkthrough

The e2e-aws-techpreview CI job now runs only when changed files match the configured OS image stream pattern.

Changes

Techpreview pipeline triggering

Layer / File(s)	Summary
Add OS image stream change filter ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml	Adds pipeline_run_if_changed patterns for OS image stream-related changes to the e2e-aws-techpreview job.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: jbpratt

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the CI job trigger change for OSImageStream-related updates in openshift/hypershift.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Only ci-operator YAML changed; no Ginkgo test titles or code under test were modified.
Test Structure And Quality	✅ Passed	PR only updates CI job config annotations; no Ginkgo test code was added or changed, so this test-structure review is not applicable.
Microshift Test Compatibility	✅ Passed	This PR only changes CI job configuration; no new Ginkgo tests or test bodies were added to assess for MicroShift compatibility.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	This PR only adds CI trigger annotations; it introduces no new Ginkgo tests or SNO-relevant test logic to assess.
Topology-Aware Scheduling Compatibility	✅ Passed	Only CI job trigger metadata changed; no deployment, controller, or scheduling code was added, and no topology-sensitive pod settings appear.
Ote Binary Stdout Contract	✅ Passed	Only CI YAML files changed; no process-level binaries, tests, or logging code were modified, so the stdout contract isn’t implicated.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new Ginkgo tests were added; the PR only updates CI job config/annotations, so IPv4 or external-connectivity review is not applicable.
No-Weak-Crypto	✅ Passed	Diff only adds a pipeline_run_if_changed selector to CI YAML; no crypto code, weak algorithms, or secret-comparison logic changed.
Container-Privileges	✅ Passed	The PR only adds a pipeline_run_if_changed annotation; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation fields were introduced.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only adds a path filter to the e2e-aws-techpreview CI stanza; no log statements or secret-bearing values were introduced.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@sdminonne: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-hypershift-main-e2e-aws-techpreview	openshift/hypershift	presubmit	Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@sdminonne: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.