[WIP] expand acm virt p2p jobs to ocp 4.23

[shakyav]

Summary by CodeRabbit

• Updates the RedHatQE ACM Virt P2P AWS interop CI configuration to target OCP 4.23 nightly release candidates (switching to release:latest via OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE), while keeping the variant-specific spoke cluster initialization at 4.22.
• Adjusts the MTV operator install channel setting to !default in the P2P AWS workflow.
• Adds a new RedHatQE interop-testing config for acm-virt-ocp4.23-p2p, defining the OCP 4.23 nightly targeting, AWS CI workflow steps for spoke/cluster setup and CCLM live migration (plus uninstall/cleanup chains), and updates related defaults (e.g., ODF stable channel/version and Firewatch Jira labels) for 4.23.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shakyav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• ci-operator/config/RedHatQE/interop-testing/OWNERS [shakyav]
• ci-operator/jobs/RedHatQE/interop-testing/OWNERS [shakyav]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 4265a4a5-ba74-4e50-b2fc-0a22c7c2e35f

📥 Commits

Reviewing files that changed from the base of the PR and between c021240 and e51890a.

📒 Files selected for processing (2)

• ci-operator/config/RedHatQE/interop-testing/RedHatQE-interop-testing-master__acm-virt-ocp4.22-p2p.yaml
• ci-operator/config/RedHatQE/interop-testing/RedHatQE-interop-testing-master__acm-virt-ocp4.23-p2p.yaml

🚧 Files skipped from review as they are similar to previous changes (2)

• ci-operator/config/RedHatQE/interop-testing/RedHatQE-interop-testing-master__acm-virt-ocp4.23-p2p.yaml
• ci-operator/config/RedHatQE/interop-testing/RedHatQE-interop-testing-master__acm-virt-ocp4.22-p2p.yaml

---

Walkthrough

The CI configuration redirects the existing p2p test to OCP 4.23 nightly and adds a dedicated OCP 4.23 AWS ACM virtualization interop workflow with image, resource, environment, orchestration, reporting, and metadata settings.

Changes

OCP 4.23 interop configuration

Layer / File(s)	Summary
Release and image setup ci-operator/config/RedHatQE/interop-testing/...acm-virt-ocp4.22-p2p.yaml, ci-operator/config/RedHatQE/interop-testing/...acm-virt-ocp4.23-p2p.yaml	Selects the OCP 4.23 nightly candidate, defines base and derived images, installs CLI tooling, and sets resource requests.
AWS interop workflow ci-operator/config/RedHatQE/interop-testing/...acm-virt-ocp4.22-p2p.yaml, ci-operator/config/RedHatQE/interop-testing/...acm-virt-ocp4.23-p2p.yaml	Updates the release override and MTV channel, and defines the scheduled AWS workflow with environment, orchestration, Firewatch, leases, and timeout settings.
Variant metadata ci-operator/config/RedHatQE/interop-testing/...acm-virt-ocp4.23-p2p.yaml	Adds generated metadata for the OCP 4.23 p2p variant.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant CIOperator
  participant AWSCluster
  participant InteropWorkflow
  participant Firewatch
  CIOperator->>AWSCluster: Install OCP 4.23 nightly release
  CIOperator->>InteropWorkflow: Run pre, test, and post chains
  InteropWorkflow->>AWSCluster: Configure ACM, ODF, Submariner, and MTV migration steps
  InteropWorkflow->>Firewatch: Report failures using configured rules

Loading

Possibly related PRs

• openshift/release#82106: Updates the same interop configuration’s MTV operator channel.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: expanding ACM Virt P2P jobs to OCP 4.23.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No Ginkgo test titles were added or changed; the PR only updates static CI job/YAML config names and parameters.
Test Structure And Quality	✅ Passed	PR only updates ci-operator YAML operator channels; no Ginkgo test code or test logic changed, so the test-structure review is not applicable.
Microshift Test Compatibility	✅ Passed	Only ci-operator job YAML changed; no new Ginkgo tests, APIs, or MicroShift-unsafe code were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only changes CI YAML/job wiring; no new Ginkgo test source or SNO-sensitive assumptions were added.
Topology-Aware Scheduling Compatibility	✅ Passed	PR only updates ci-operator test configs; no deployment manifests/controllers were changed and no nodeSelector, affinity, anti-affinity, spread, or replica settings appear.
Ote Binary Stdout Contract	✅ Passed	PR only changes ci-operator YAML job configs; no process-level code or stdout writes were introduced in the touched paths.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only adds/updates CI YAML; no new Ginkgo test code or hardcoded IPv4 literals were introduced, and the job reuses existing shared chains.
No-Weak-Crypto	✅ Passed	Touched YAMLs only update release/channel/version settings; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons appear.
Container-Privileges	✅ Passed	Touched YAMLs only change MTV channel; no privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/root/allowPrivilegeEscalation settings are present.
No-Sensitive-Data-In-Logs	✅ Passed	No sensitive data was added to logs/config; the only PII-like value is an existing Jira assignee email carried over unchanged.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[shakyav]

/pj-rehearse periodic-ci-RedHatQE-interop-testing-master-acm-virt-ocp4.23-p2p-cclm-liv-mig-aws-p2p-lp-interop-aws

[openshift-merge-bot]

@shakyav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-merge-bot]

[REHEARSALNOTIFIER]
@shakyav: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-RedHatQE-interop-testing-master-acm-virt-ocp4.23-p2p-images	RedHatQE/interop-testing	presubmit	Presubmit changed
pull-ci-RedHatQE-interop-testing-master-acm-virt-ocp4.22-p2p-images	RedHatQE/interop-testing	presubmit	Ci-operator config changed
periodic-ci-RedHatQE-interop-testing-master-acm-virt-ocp4.22-p2p-cclm-liv-mig-aws-p2p-lp-interop-aws	N/A	periodic	Periodic changed
periodic-ci-RedHatQE-interop-testing-master-acm-virt-ocp4.23-p2p-cclm-liv-mig-aws-p2p-lp-interop-aws	N/A	periodic	Periodic changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[shakyav]

/pj-rehearse periodic-ci-RedHatQE-interop-testing-master-acm-virt-ocp4.22-p2p-cclm-liv-mig-aws-p2p-lp-interop-aws

[openshift-merge-bot]

@shakyav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[shakyav]

/pj-rehearse abort

[openshift-merge-bot]

@shakyav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci]

@shakyav: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/rehearse/periodic-ci-RedHatQE-interop-testing-master-acm-virt-ocp4.23-p2p-cclm-liv-mig-aws-p2p-lp-interop-aws	c021240	link	unknown	/pj-rehearse periodic-ci-RedHatQE-interop-testing-master-acm-virt-ocp4.23-p2p-cclm-liv-mig-aws-p2p-lp-interop-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.