ROSAENG-58795 | task: add nested podman image for on-demand to rosa-clusters-service#82109
ROSAENG-58795 | task: add nested podman image for on-demand to rosa-clusters-service#82109davidleerh wants to merge 3 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidleerh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe Konflux configuration replaces the image-stream-tag build root with a nested-Podman-based ChangesROSA clusters service CI
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@davidleerh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@davidleerh: job(s): pr-check-rosa-hcp either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse ack |
|
@davidleerh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/pj-rehearse pull-ci-openshift-online-rosa-clusters-service-konflux-master-pr-check-rosa-hcp |
|
@davidleerh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
ci-operator/config/openshift-online/rosa-clusters-service/openshift-online-rosa-clusters-service-konflux-master.yaml (1)
56-64: 📐 Maintainability & Code Quality | 🔵 TrivialRun
make updatefor this ci-operator config change. Regenerate the corresponding Prow jobs so the generated config stays in sync.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift-online/rosa-clusters-service/openshift-online-rosa-clusters-service-konflux-master.yaml` around lines 56 - 64, Run make update to regenerate the corresponding Prow jobs for the modified ci-operator configuration, ensuring generated files remain synchronized with the changes near the nested_podman and pr_check.sh settings.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift-online/rosa-clusters-service/openshift-online-rosa-clusters-service-konflux-master.yaml`:
- Around line 16-17: Update the Dockerfile COPY instruction so the repository
contents are copied directly into /opt/app-root/src/rosa-clusters-service,
matching the WORKDIR used by subsequent commands such as ./pr_check.sh. Keep the
existing WORKDIR unchanged.
---
Nitpick comments:
In
`@ci-operator/config/openshift-online/rosa-clusters-service/openshift-online-rosa-clusters-service-konflux-master.yaml`:
- Around line 56-64: Run make update to regenerate the corresponding Prow jobs
for the modified ci-operator configuration, ensuring generated files remain
synchronized with the changes near the nested_podman and pr_check.sh settings.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 2a4c0290-2be7-41c4-9a8b-09b08441240c
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift-online/rosa-clusters-service/openshift-online-rosa-clusters-service-konflux-master-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift-online/rosa-clusters-service/openshift-online-rosa-clusters-service-konflux-master.yaml
openshift-merge-bot
Bot
removed
the
rehearsals-ack
|
/pj-rehearse pull-ci-openshift-online-rosa-clusters-service-konflux-master-pr-check-rosa-hcp |
|
@davidleerh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-online-rosa-clusters-service-konflux-master-pr-check-rosa-hcp |
|
@davidleerh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@davidleerh: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/pj-rehearse ack |
|
@davidleerh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
1 participant
Summary by CodeRabbit
ci-operator/config/openshift-online/rosa-clusters-service/openshift-online-rosa-clusters-service-konflux-master.yaml) to build and use a new nested Podman-basedgolang-plusimage: addsbase_images.nested-podmanand definesimages.itemsto creategolang-plusvia an inlinedockerfile_literalthat installs build tooling (git,go,make,jq,python3/pip,skopeo) and fetches the OpenShift CLI (oc) on top ofnested-podman, copying the reposrcinto/opt/app-root/src/rosa-clusters-service.pr-check-rosa-hcp,pr-check-aws,pr-check-gcp,pr-check-rosa-classic,pr-check-core) to run with nested Podman enabled by settingcapabilities: [nested-podman]andnested_podman: true, switching theircontainer.fromfromsrcto the newgolang-plusimage while keeping the existing./pr_check.sh --<target>command variants and mounting therosa-clusters-service-sandboxsecret at/usr/local/rosa-clusters-service-sandbox.