Skip to content

ROSAENG-60068: Add Prow e2e jobs for configure-alertmanager-operator#82101

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
dustman9000:rosaeng-60068/camo-prow-e2e
Jul 20, 2026
Merged

ROSAENG-60068: Add Prow e2e jobs for configure-alertmanager-operator#82101
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
dustman9000:rosaeng-60068/camo-prow-e2e

Conversation

@dustman9000

@dustman9000 dustman9000 commented Jul 17, 2026

Copy link
Copy Markdown
Member

Add Prow e2e test jobs for CAMO using the rosa-cluster-lease-e2e-workflow:

  • Presubmit: rosa-sts-e2e (optional, run_if_changed)
  • Periodic int: rosa-sts-e2e-promotion-int (LEASE_ENV=integration, Gangway-only)
  • Periodic stage: rosa-sts-e2e-promotion-stage (LEASE_ENV=staging, Gangway-only)

Also adds operator-e2e and operator-pko image builds via dockerfile_literal.

Part of the SRE operator e2e Prow migration (ROSAENG-60066).

Jira: https://redhat.atlassian.net/browse/ROSAENG-60068

Summary by CodeRabbit

  • Updates CAMO’s OpenShift Prow CI configuration to add ROSA STS E2E coverage via the rosa-cluster-lease-e2e-workflow, affecting CI job generation for configure-alertmanager-operator:
    • Adds an optional, change-triggered presubmit job rosa-sts-e2e (gated with run_if_changed).
    • Adds two cron-based periodic promotion jobs, rosa-sts-e2e-promotion-int and rosa-sts-e2e-promotion-stage, which run with Gangway only, use the shared rosa-e2e-01 cluster profile, and differ by LEASE_ENV (integration vs staging).
    • Both promotion jobs report success/failure/error via a status-based report_template to #rosa-prow-info.
  • Extends the same CI config’s image build targets to support the SRE operator E2E Prow migration by introducing operator-e2e and operator-pko image builds using dockerfile_literal (including copying deploy_pko and compiling the E2E test binary), alongside the existing configure-alertmanager-operator Dockerfile build; also adds base_images.rosa-aws-cli and updates releases.latest.candidate.version to 4.22.
  • Improves the ROSA operator E2E install flow configurability by introducing CLUSTER_PACKAGE_NAME handling for PKO:
    • rosa-operator-install-ref.yaml adds the overridable CLUSTER_PACKAGE_NAME env var (default "", intended to avoid collisions and allow custom naming when needed).
    • rosa-operator-install-commands.sh preserves a caller-provided CLUSTER_PACKAGE_NAME and only falls back to ${OPERATOR_NAME}-e2e-test when unset.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@dustman9000: This pull request references ROSAENG-60068 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Add Prow e2e test jobs for CAMO using the rosa-cluster-lease-e2e-workflow:

  • Presubmit: rosa-sts-e2e (optional, run_if_changed)
  • Periodic int: rosa-sts-e2e-promotion-int (LEASE_ENV=integration, Gangway-only)
  • Periodic stage: rosa-sts-e2e-promotion-stage (LEASE_ENV=staging, Gangway-only)

Also adds operator-e2e and operator-pko image builds via dockerfile_literal.

Part of the SRE operator e2e Prow migration (ROSAENG-60066).

Jira: https://redhat.atlassian.net/browse/ROSAENG-60068

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 86aaa318-6d62-4d60-a54b-433f16affee2

📥 Commits

Reviewing files that changed from the base of the PR and between 0644da4 and 7348df7.

⛔ Files ignored due to path filters (3)
  • ci-operator/jobs/openshift/configure-alertmanager-operator/openshift-configure-alertmanager-operator-master-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/configure-alertmanager-operator/openshift-configure-alertmanager-operator-master-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/configure-alertmanager-operator/openshift-configure-alertmanager-operator-master-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (3)
  • ci-operator/config/openshift/configure-alertmanager-operator/openshift-configure-alertmanager-operator-master.yaml
  • ci-operator/step-registry/rosa/operator/install/rosa-operator-install-commands.sh
  • ci-operator/step-registry/rosa/operator/install/rosa-operator-install-ref.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
  • ci-operator/step-registry/rosa/operator/install/rosa-operator-install-ref.yaml
  • ci-operator/config/openshift/configure-alertmanager-operator/openshift-configure-alertmanager-operator-master.yaml

Walkthrough

The pipeline adds ROSA AWS CLI and operator/E2E image builds, targets OpenShift 4.22, and defines optional and scheduled ROSA STS E2E jobs. Operator installation now supports overriding the generated ClusterPackage name.

Changes

ROSA STS E2E integration

Layer / File(s) Summary
Pipeline builds and ROSA E2E jobs
ci-operator/config/openshift/configure-alertmanager-operator/openshift-configure-alertmanager-operator-master.yaml
Adds ROSA AWS CLI and operator-related image targets, updates the candidate release to 4.22, and adds optional and scheduled ROSA STS E2E jobs.
Configurable ClusterPackage naming
ci-operator/step-registry/rosa/operator/install/rosa-operator-install-ref.yaml, ci-operator/step-registry/rosa/operator/install/rosa-operator-install-commands.sh
Adds CLUSTER_PACKAGE_NAME configuration and preserves it when set, otherwise defaulting to ${OPERATOR_NAME}-e2e-test.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Prow as Prow test job
  participant Workflow as rosa-cluster-lease-e2e-workflow
  participant E2E as ROSA STS E2E
  participant Reporter as rosa-prow-info
  Prow->>Workflow: run workflow with operator images and lease environment
  Workflow->>E2E: execute E2E tests
  E2E-->>Prow: return job outcome
  Prow->>Reporter: report success, failure, or error
Loading

Suggested reviewers: cdoan1, psav

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Ipv6 And Disconnected Network Test Compatibility ⚠️ Warning The new ROSA e2e workflow depends on OCM/backplane login for cluster access, so it requires external services and won’t work in disconnected CI. Mark the underlying e2e cases/job as cloud-only or add [Skipped:Disconnected] for any external-service-dependent paths; provide a disconnected-compatible variant if needed.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: adding Prow e2e jobs for configure-alertmanager-operator.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The commit changes only CI YAML and a ROSA install script; no changed file contains Ginkgo titles (It/Describe/Context/When).
Test Structure And Quality ✅ Passed PR only changes CI config and install scripts; no Ginkgo *_test.go files or test assertions were modified.
Microshift Test Compatibility ✅ Passed Only CI config and install scripts changed; no new Ginkgo test code or MicroShift-incompatible APIs were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No Ginkgo e2e test code was added; the PR only changes CI/job config and a shell install script, with no new SNO-sensitive assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed Only CI job wiring and a PKO install default changed; no deployment manifests, controllers, or scheduling constraints were added.
Ote Binary Stdout Contract ✅ Passed No process-level stdout writes were introduced; the touched shell script logs to stderr and the other changes are config-only.
No-Weak-Crypto ✅ Passed No MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret/token comparisons were added in the changed files.
Container-Privileges ✅ Passed Changed CI/job manifests add no privileged, hostPID/Network/IPC, SYS_ADMIN, runAsUser/root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The PR adds no new sensitive logging; the only script change is a CLUSTER_PACKAGE_NAME fallback, and YAML additions are job/image config plus a log-link template.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 17, 2026
@openshift-ci
openshift-ci Bot requested review from cdoan1 and psav July 17, 2026 18:36
@dustman9000

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-configure-alertmanager-operator-master-rosa-sts-e2e periodic-ci-openshift-configure-alertmanager-operator-master-rosa-sts-e2e-promotion-stage

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@dustman9000
dustman9000 force-pushed the rosaeng-60068/camo-prow-e2e branch from 6eab63e to 06b197d Compare July 18, 2026 00:11
@dustman9000

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-configure-alertmanager-operator-master-rosa-sts-e2e periodic-ci-openshift-configure-alertmanager-operator-master-rosa-sts-e2e-promotion-stage

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@dustman9000

Copy link
Copy Markdown
Member Author

/retest ci/rehearse/openshift/configure-alertmanager-operator/master/rosa-sts-e2e

@dustman9000

Copy link
Copy Markdown
Member Author

/retest

@dustman9000

Copy link
Copy Markdown
Member Author

/test ci/rehearse/openshift/configure-alertmanager-operator/master/rosa-sts-e2e

@dustman9000

Copy link
Copy Markdown
Member Author

/test ci/rehearse/periodic-ci-openshift-configure-alertmanager-operator-master-rosa-sts-e2e-promotion-stage

@dustman9000

Copy link
Copy Markdown
Member Author

/retest

@dustman9000

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-configure-alertmanager-operator-master-rosa-sts-e2e periodic-ci-openshift-configure-alertmanager-operator-master-rosa-sts-e2e-promotion-stage

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@dustman9000

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-configure-alertmanager-operator-master-rosa-sts-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@dustman9000

Copy link
Copy Markdown
Member Author

/pj-rehearse periodic-ci-openshift-configure-alertmanager-operator-master-rosa-sts-e2e-promotion-stage

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@dustman9000
dustman9000 force-pushed the rosaeng-60068/camo-prow-e2e branch from 06b197d to 0644da4 Compare July 18, 2026 04:43
@dustman9000

Copy link
Copy Markdown
Member Author

/pj-rehearse periodic-ci-openshift-configure-alertmanager-operator-master-rosa-sts-e2e-promotion-stage

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@dustman9000
dustman9000 force-pushed the rosaeng-60068/camo-prow-e2e branch from 0644da4 to 7348df7 Compare July 18, 2026 06:42
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@dustman9000: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-configure-alertmanager-operator-master-rosa-sts-e2e openshift/configure-alertmanager-operator presubmit Presubmit changed
pull-ci-openshift-configure-alertmanager-operator-master-coverage openshift/configure-alertmanager-operator presubmit Ci-operator config changed
pull-ci-openshift-configure-alertmanager-operator-master-e2e-binary-build-success openshift/configure-alertmanager-operator presubmit Ci-operator config changed
pull-ci-openshift-configure-alertmanager-operator-master-images openshift/configure-alertmanager-operator presubmit Ci-operator config changed
pull-ci-openshift-configure-alertmanager-operator-master-lint openshift/configure-alertmanager-operator presubmit Ci-operator config changed
pull-ci-openshift-configure-alertmanager-operator-master-test openshift/configure-alertmanager-operator presubmit Ci-operator config changed
pull-ci-openshift-configure-alertmanager-operator-master-validate openshift/configure-alertmanager-operator presubmit Ci-operator config changed
pull-ci-openshift-route-monitor-operator-master-rosa-sts-e2e openshift/route-monitor-operator presubmit Registry content changed
periodic-ci-openshift-configure-alertmanager-operator-master-rosa-sts-e2e-promotion-int N/A periodic Periodic changed
periodic-ci-openshift-configure-alertmanager-operator-master-rosa-sts-e2e-promotion-stage N/A periodic Periodic changed
periodic-ci-openshift-route-monitor-operator-master-rosa-sts-e2e-promotion-int N/A periodic Registry content changed
periodic-ci-openshift-route-monitor-operator-master-rosa-sts-e2e-promotion-stage N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@dustman9000

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-configure-alertmanager-operator-master-rosa-sts-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@dustman9000

Copy link
Copy Markdown
Member Author

/pj-rehearse rosa-sts-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@dustman9000

Copy link
Copy Markdown
Member Author

/retest

@dustman9000

Copy link
Copy Markdown
Member Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@dustman9000

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-configure-alertmanager-operator-master-rosa-sts-e2e

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: job(s): rosa-sts-e2e either don't exist or were not found to be affected, and cannot be rehearsed

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dustman9000

Copy link
Copy Markdown
Member Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@dustman9000: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 20, 2026
@Mhodesty

Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2026
@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000, Mhodesty, redhat-chai-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephomaniac

Copy link
Copy Markdown
Contributor

/retest

@nephomaniac

Copy link
Copy Markdown
Contributor

/rebase

@dustman9000

Copy link
Copy Markdown
Member Author

/retest

@dustman9000

Copy link
Copy Markdown
Member Author

/retest-required

@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@dustman9000: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit c74265c into openshift:main Jul 20, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants