Skip to content

MG-272: Add periodic HyperShift CI job for support-log-gather-operator 4.22#82089

Open
neha037 wants to merge 1 commit into
openshift:mainfrom
neha037:MG-272-hypershift-periodic-v2
Open

MG-272: Add periodic HyperShift CI job for support-log-gather-operator 4.22#82089
neha037 wants to merge 1 commit into
openshift:mainfrom
neha037:MG-272-hypershift-periodic-v2

Conversation

@neha037

@neha037 neha037 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds a weekly HyperShift periodic CI job (e2e-aws-hypershift-operator-weekly) for the must-gather-operator on release-4.22
  • Uses hypershift-aws-create chain with ENABLE_ICSP=true to bake Konflux image mirrors into the hosted cluster at creation time
  • Installs the operator from the Konflux FBC release catalog via optional-operators-subscribe
  • Includes nested management cluster provisioning, ICSP setup, KUBECONFIG switching, and full cleanup

Test plan

  • CI validation checks pass
  • /pj-rehearse triggers rehearsal of the HyperShift periodic job
  • Rehearsal: management cluster provisions, hosted cluster creates with ICSP, operator installs via OLM, e2e tests run

Supersedes #81737

🤖 Generated with Claude Code

Summary by CodeRabbit

Adds a weekly HyperShift AWS end-to-end CI job for the must-gather-operator on release-4.22. The job provisions a nested management cluster, installs the operator from the Konflux FBC catalog with ICSP enabled, runs e2e tests, and cleans up afterward. It also adds the required multi-architecture candidate release configuration and image mirror setup.

…r 4.22

Uses hypershift-aws-create chain with ENABLE_ICSP=true to bake Konflux
image mirrors into the hosted cluster at creation time. Installs the
operator from the Konflux FBC release catalog via optional-operators-subscribe.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@neha037: This pull request references MG-272 which is a valid jira issue.

Details

In response to this:

Summary

  • Adds a weekly HyperShift periodic CI job (e2e-aws-hypershift-operator-weekly) for the must-gather-operator on release-4.22
  • Uses hypershift-aws-create chain with ENABLE_ICSP=true to bake Konflux image mirrors into the hosted cluster at creation time
  • Installs the operator from the Konflux FBC release catalog via optional-operators-subscribe
  • Includes nested management cluster provisioning, ICSP setup, KUBECONFIG switching, and full cleanup

Test plan

  • CI validation checks pass
  • /pj-rehearse triggers rehearsal of the HyperShift periodic job
  • Rehearsal: management cluster provisions, hosted cluster creates with ICSP, operator installs via OLM, e2e tests run

Supersedes #81737

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Changes

Release 4.22 Hypershift testing

Layer / File(s) Summary
Multi-architecture candidate release
ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-4.22.yaml
Adds the multi-latest nightly multi-architecture candidate for OCP 4.22.
Weekly AWS Hypershift end-to-end pipeline
ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-4.22.yaml
Adds a weekly Hypershift test using the new release image, ICSP configuration, rollout verification, and make test-e2e.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant WeeklyTest as e2e-aws-hypershift-operator-weekly
  participant Hypershift as hypershift-aws
  participant ICSP as setup-konflux-icsp
  participant Operator as must-gather-operator
  participant E2E as make test-e2e
  WeeklyTest->>Hypershift: Set up nested management cluster
  WeeklyTest->>ICSP: Write mgmt_icsp.yaml
  WeeklyTest->>Hypershift: Configure guest kubeconfig and pull-secret mirroring
  WeeklyTest->>Operator: Verify deployment rollout
  WeeklyTest->>E2E: Run end-to-end tests
  WeeklyTest->>Hypershift: Tear down the test environment
Loading

Suggested reviewers: shivprakashmuley

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Ipv6 And Disconnected Network Test Compatibility ⚠️ Warning The new periodic job references quay.io and registry.redhat.io in OO_INDEX/ICSP mirrors, so it depends on external registry connectivity. Mirror all images through an internal registry/catalog reachable without public internet, or mark the job [Skipped:Disconnected] if internet access is unavoidable.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding a periodic HyperShift CI job for the 4.22 support-log-gather-operator.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The patch only adds static CI job wiring; no It/Describe/Context titles or dynamic identifiers appear in the changed config or generated periodic job.
Test Structure And Quality ✅ Passed PR only changes CI config/generated Prow jobs; no Ginkgo test code was added, so the test-structure check is not applicable.
Microshift Test Compatibility ✅ Passed PR only adds a periodic CI job/config; it adds no new Ginkgo test code, so the MicroShift compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Config-only PR adds a periodic job; no new Ginkgo test code or SNO-unsafe test logic was introduced.
Topology-Aware Scheduling Compatibility ✅ Passed PR only adds ci-operator/job YAML; no deployment manifests, controllers, or pod scheduling fields (nodeSelector/affinity/spread/PDB) were introduced.
Ote Binary Stdout Contract ✅ Passed PR only changes CI YAML and generated job config; no process-level binary code or stdout writes were introduced.
No-Weak-Crypto ✅ Passed Changed YAML only adds CI jobs and ICSP setup; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto code found.
Container-Privileges ✅ Passed Inspected the new periodic config and generated Prow job; neither contains privileged: true, hostPID/hostNetwork/hostIPC, SYS_ADMIN, or allowPrivilegeEscalation.
No-Sensitive-Data-In-Logs ✅ Passed The new job only mounts/copies secret files and applies ICSP YAML; it doesn’t echo or print tokens, passwords, PII, or internal hostnames.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from Tafhim and dustman9000 July 17, 2026 15:39
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: neha037
Once this PR has been reviewed and has the lgtm label, please assign typeid for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-4.22.yaml`:
- Around line 203-204: Regenerate the Prow job output for the
e2e-aws-hypershift-operator-weekly periodic test by running make update, then
commit the resulting generated configuration, including any updated
zz_generated_metadata and Prow job files.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b09e4ae7-8c59-4413-b5cf-fae50903b530

📥 Commits

Reviewing files that changed from the base of the PR and between a710bb3 and 51caff2.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/must-gather-operator/openshift-must-gather-operator-release-4.22-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-4.22.yaml

Comment on lines +203 to +204
- as: e2e-aws-hypershift-operator-weekly
cron: '@weekly'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Regenerate the Prow job for this new periodic test.

Adding this named cron test changes generated job configuration, but the PR includes only the source config. Run make update and commit the affected generated Prow job output before merge. As per coding guidelines, “run make update after changes to regenerate zz_generated_metadata and Prow jobs.”

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/openshift/must-gather-operator/openshift-must-gather-operator-release-4.22.yaml`
around lines 203 - 204, Regenerate the Prow job output for the
e2e-aws-hypershift-operator-weekly periodic test by running make update, then
commit the resulting generated configuration, including any updated
zz_generated_metadata and Prow job files.

Source: Coding guidelines

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@neha037: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@neha037

neha037 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@neha037: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants