Skip to content

NetObserv testing#82088

Open
Amoghrd wants to merge 1 commit into
openshift:mainfrom
Amoghrd:netobserv-testing-2
Open

NetObserv testing#82088
Amoghrd wants to merge 1 commit into
openshift:mainfrom
Amoghrd:netobserv-testing-2

Conversation

@Amoghrd

@Amoghrd Amoghrd commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Updates the Network Observability Operator nightly 4.22 CI jobs to allow six additional hours and wait for asynchronous test completion in three test sequences.

@Amoghrd

Amoghrd commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 17, 2026
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 5c475d6e-2a69-46ce-bdf7-06503b5f80b1

📥 Commits

Reviewing files that changed from the base of the PR and between 87a0445 and f8ff17b.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/network-observability-operator/openshift-network-observability-operator-release-2.0__nightly-4.22.yaml

Walkthrough

The nightly 4.22 configuration adds a six-hour timeout extension and trailing wait step to three Network Observability test jobs.

Changes

Network Observability nightly jobs

Layer / File(s) Summary
Extend job timeout and append wait steps
ci-operator/config/openshift/network-observability-operator/...nightly-4.22.yaml
Three metal and vSphere jobs now add TIMEOUT: + 6 hours and a trailing wait step after their existing test chains.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: memodi

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is related to the NetObserv job changes but is too vague to describe the actual CI timeout and wait-step update. Rename it to summarize the specific CI config change, e.g. increase nightly NetObserv test timeouts and add wait steps.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only changes CI YAML timeout/wait steps; no Ginkgo test titles were added or modified.
Test Structure And Quality ✅ Passed Only a ci-operator YAML job config changed; no Ginkgo test code was modified, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed Only a ci-operator YAML timeout/wait change was added; no new Ginkgo tests or MicroShift-relevant APIs were introduced.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The PR only changes ci-operator YAML for timeouts/wait steps; no new Ginkgo tests or SNO-sensitive assumptions were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only a ci-operator test config changed; no deployment manifests, controllers, or scheduling constraints were added.
Ote Binary Stdout Contract ✅ Passed Only a ci-operator YAML job config changed (TIMEOUT and wait steps); no OTE binary or process-level stdout code was modified.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only a CI YAML job config changed; no new Ginkgo tests or network code were added, so the IPv6/disconnected check is not applicable.
No-Weak-Crypto ✅ Passed PR only updates CI YAML timeout/wait steps; the touched file contains no weak-crypto usage or custom crypto code.
Container-Privileges ✅ Passed The PR only adds TIMEOUT/wait steps; no privileged:true, hostPID/hostNetwork/hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root settings appear.
No-Sensitive-Data-In-Logs ✅ Passed Diff only adds TIMEOUT and wait steps in a CI YAML; no new logging of secrets, PII, or customer data was introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from jotak and luisjira July 17, 2026 15:20
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Amoghrd
Once this PR has been reviewed and has the lgtm label, please assign leandroberetta for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@Amoghrd: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Amoghrd

Amoghrd commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse list

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant