Skip to content

AGENT-1556: Add iso-no-registry tests to 4.22#82087

Open
bfournie wants to merge 1 commit into
openshift:mainfrom
bfournie:agent-iso-no-registry-4.22
Open

AGENT-1556: Add iso-no-registry tests to 4.22#82087
bfournie wants to merge 1 commit into
openshift:mainfrom
bfournie:agent-iso-no-registry-4.22

Conversation

@bfournie

@bfournie bfournie commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

This adds the iso-no-registry tests for 4.22 that were removed in #78986.

Summary by CodeRabbit

Restores iso-no-registry agent ISO conformance coverage for OpenShift 4.22 by adding four new nightly Prow test entries to ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml for the equinix-ocp-metal cluster profile. Each job runs the agent-e2e-generic-conformance-iso-no-registry workflow with DEVSCRIPTS_CONFIG configured for AGENT_E2E_TEST_BOOT_MODE=ISO_NO_REGISTRY, ISO builder cache cleanup (AGENT_CLEANUP_ISO_BUILDER_CACHE_LOCAL_DEV=true), and FEATURE_SET=TechPreviewNoUpgrade, using scenario-specific values and cron schedules:

  • e2e-agent-compact-iso-no-registry (COMPACT_IPV4), cron 0 2/8 * * *
  • e2e-agent-ha-dualstack-iso-no-registry (HA_IPV4V6), cron 30 2/8 * * *, timeout: 4h0m0s
  • e2e-agent-ha5-dualstack-iso-no-registry (5CONTROL_IPV4V6), cron 0 3/8 * * *, timeout: 4h0m0s
  • e2e-agent-sno-ipv4-iso-no-registry (SNO_IPV4), cron 30 3/8 * * *, node_architecture: amd64, plus AGENT_PLATFORM_TYPE=none

@openshift-ci-robot

openshift-ci-robot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@bfournie: This pull request references AGENT-1556 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

This adds the iso-no-registry tests for 4.22 that were removed in #78986.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2026
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 54348284-709d-42f8-b642-71d9eda8e0d3

📥 Commits

Reviewing files that changed from the base of the PR and between c476c18 and 392314c.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml

Walkthrough

Adds four scheduled agent ISO no-registry TechPreview conformance jobs to the nightly 4.22 release configuration, including scenario-specific schedules and SNO IPv4 platform settings.

Changes

Agent ISO conformance

Layer / File(s) Summary
Configure scheduled ISO conformance jobs
ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml
Adds four equinix-ocp-metal test entries using the ISO no-registry workflow, TechPreview settings, scenario-specific cron schedules, optional four-hour timeouts, and SNO-specific architecture and platform configuration.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: neisw, xueqzhan

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding iso-no-registry tests for 4.22.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only CI config YAML changed; no It/Describe/Context/When test titles were added, and the new job names are static.
Test Structure And Quality ✅ Passed Only CI config YAML changed; no Ginkgo/Go test code was modified, so the test-quality review is not applicable.
Microshift Test Compatibility ✅ Passed No Ginkgo test code was added; only CI job entries referencing existing workflows, so MicroShift test-compatibility review is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo test code was added; this is CI job config only. The SNO job is explicitly SNO_IPV4 with AGENT_PLATFORM_TYPE=none.
Topology-Aware Scheduling Compatibility ✅ Passed Only CI job definitions changed in ci-operator YAML; no deployment manifests, controllers, or scheduling constraints were added.
Ote Binary Stdout Contract ✅ Passed PR only adds CI YAML jobs; no process-level code or stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only adds CI job config; the referenced workflow/refs use oc and openshift-tests, set OPENSHIFT_SKIP_EXTERNAL_TESTS=true, and show no hardcoded IPv4 literals or public-network fetches.
No-Weak-Crypto ✅ Passed Patch only adds YAML job configs; scanned 399 added lines and found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto/comparison code.
Container-Privileges ✅ Passed No privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation or explicit root settings were added in the new jobs or config.
No-Sensitive-Data-In-Logs ✅ Passed The added CI jobs only set non-sensitive env/config values; no passwords, tokens, PII, hostnames, or log statements were introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from neisw and xueqzhan July 17, 2026 14:58
Comment thread ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml Outdated
@bfournie
bfournie force-pushed the agent-iso-no-registry-4.22 branch from d111de9 to c476c18 Compare July 17, 2026 15:12
Comment thread ci-operator/config/openshift/release/openshift-release-main__nightly-4.22.yaml Outdated
This adds the iso-no-registry tests for 4.22 that were
removed in openshift#78986.
@bfournie
bfournie force-pushed the agent-iso-no-registry-4.22 branch from c476c18 to 392314c Compare July 17, 2026 16:19
@andfasano

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2026
@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andfasano, bfournie
Once this PR has been reviewed and has the lgtm label, please assign xueqzhan for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bfournie

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@bfournie

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha5-dualstack-iso-no-registry

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@bfournie: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha5-dualstack-iso-no-registry 392314c link unknown /pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-agent-ha5-dualstack-iso-no-registry

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bfournie

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants