Add winfio_vm and winfio_vm_scale CI test steps for benchmark-runner#79894
Add winfio_vm and winfio_vm_scale CI test steps for benchmark-runner#79894ebattat wants to merge 3 commits into
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ebattat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds two winfio benchmark test entries using a Windows Server MSSQL 2025 image, updates the benchmark-runner script to accept that image URL, and adds Changeswinfio Workload Support with Windows MSSQL 2025 Image
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/redhat-performance/benchmark-runner/redhat-performance-benchmark-runner-commands.sh`:
- Line 130: Update the documented allowed values for the WINDOWS_IMAGE parameter
so it matches the script: add the value windows_server_mssql_2025 to the list of
allowed images in the redhat-performance-benchmark-runner-ref.yaml documentation
(the WINDOWS_IMAGE variable currently lists windows11, windows_server_2022,
windows_server_2025 but the script accepts windows_server_mssql_2025); ensure
the YAML description and any enumerated/validation entries referencing
WINDOWS_IMAGE include windows_server_mssql_2025 so docs and
redhat-performance-benchmark-runner-commands.sh are consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: a545cab8-164d-446d-821f-81e7a8716b73
⛔ Files ignored due to path filters (1)
ci-operator/jobs/redhat-performance/benchmark-runner/redhat-performance-benchmark-runner-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (3)
ci-operator/config/redhat-performance/benchmark-runner/redhat-performance-benchmark-runner-main__test-step.yamlci-operator/step-registry/redhat-performance/OWNERSci-operator/step-registry/redhat-performance/benchmark-runner/redhat-performance-benchmark-runner-commands.sh
| case "${WINDOWS_IMAGE}" in | ||
| windows_server_2022) [[ -n "${WINDOWS_SERVER_2022_URL:-}" ]] && export WINDOWS_URL="${WINDOWS_SERVER_2022_URL}" ;; | ||
| windows_server_2025) [[ -n "${WINDOWS_SERVER_2025_URL:-}" ]] && export WINDOWS_URL="${WINDOWS_SERVER_2025_URL}" ;; | ||
| windows_server_mssql_2025) [[ -n "${WINDOWS_SERVER_MSSQL_2025_URL:-}" ]] && export WINDOWS_URL="${WINDOWS_SERVER_MSSQL_2025_URL}" ;; |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Verify WINDOWS_IMAGE documentation includes windows_server_mssql_2025
rg -n 'WINDOWS_IMAGE' ci-operator/step-registry/redhat-performance/benchmark-runner/redhat-performance-benchmark-runner-ref.yaml -A 2Repository: openshift/release
Length of output: 223
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== ref.yaml WINDOWS_IMAGE documentation =="
rg -n 'WINDOWS_IMAGE' ci-operator/step-registry/redhat-performance/benchmark-runner/redhat-performance-benchmark-runner-ref.yaml -A 4
echo
echo "== usages of windows_server_mssql_2025 =="
rg -n 'windows_server_mssql_2025' ci-operator/step-registry/redhat-performance/benchmark-runner -S || true
echo
echo "== any other ref.yaml docs elsewhere =="
rg -n 'WINDOWS_IMAGE' ci-operator/step-registry/redhat-performance/benchmark-runner -S || trueRepository: openshift/release
Length of output: 2092
Update WINDOWS_IMAGE documentation to include windows_server_mssql_2025
redhat-performance-benchmark-runner-ref.yaml documents WINDOWS_IMAGE as (windows11, windows_server_2022, windows_server_2025) but redhat-performance-benchmark-runner-commands.sh accepts windows_server_mssql_2025; update the documented allowed values (ref.yaml line 35).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/step-registry/redhat-performance/benchmark-runner/redhat-performance-benchmark-runner-commands.sh`
at line 130, Update the documented allowed values for the WINDOWS_IMAGE
parameter so it matches the script: add the value windows_server_mssql_2025 to
the list of allowed images in the redhat-performance-benchmark-runner-ref.yaml
documentation (the WINDOWS_IMAGE variable currently lists windows11,
windows_server_2022, windows_server_2025 but the script accepts
windows_server_mssql_2025); ensure the YAML description and any
enumerated/validation entries referencing WINDOWS_IMAGE include
windows_server_mssql_2025 so docs and
redhat-performance-benchmark-runner-commands.sh are consistent.
|
/pj-rehearse |
|
@ebattat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse abort |
|
@arpsharm: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-redhat-performance-benchmark-runner-main-test-step-winfio-vm |
|
/pj-rehearse abort |
|
@ebattat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-redhat-performance-benchmark-runner-main-test-step-winfio-vm |
|
@ebattat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
| steps: | ||
| env: | ||
| WORKLOAD: winmssql_vm | ||
| WINDOWS_IMAGE: windows_server_mssql_2025 |
|
/pj-rehearse abort |
|
@ebattat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse abort |
|
@ebattat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-redhat-performance-benchmark-runner-main-test-step-winfio-vm |
|
@ebattat: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
- Add winfio-vm test step running WORKLOAD=winfio_vm - Add winfio-vm-scale test step running WORKLOAD=winfio_vm with SCALE=2 and windows_server_mssql_2025 image - Add support for windows_server_mssql_2025 image URL mapping in commands.sh - Add arpsharm as approver and reviewer in OWNERS Co-authored-by: Cursor <cursoragent@cursor.com>
…ecret mapping - Add WINDOWS_IMAGE=windows_server_mssql_2025 to the winmssql_vm test step - Add windows_server_mssql_2025_url to the secret key mapping in commands.sh Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
[REHEARSALNOTIFIER]
A total of 33 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[REHEARSALNOTIFIER]
A total of 33 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@ebattat: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary
winfio-vmtest step that runsWORKLOAD=winfio_vmusing theredhat-performance-benchmark-runnerrefwinfio-vm-scaletest step that runsWORKLOAD=winfio_vmwithSCALE=2andWINDOWS_IMAGE=windows_server_mssql_2025for scaled testingwindows_server_mssql_2025image URL mapping (WINDOWS_SERVER_MSSQL_2025_URL) inbenchmark-runner-commands.sharpsharmas approver and reviewer in theredhat-performanceOWNERS fileTest plan
winfio-vmtest with/test test-step-winfio-vmon a benchmark-runner PRwinfio-vm-scaletest with/test test-step-winfio-vm-scaleon a benchmark-runner PRWINDOWS_SERVER_MSSQL_2025_URLenv var is picked up correctly in the scale testMade with Cursor
Summary by CodeRabbit
This PR updates OpenShift CI configuration and step scripts for the redhat-performance/benchmark-runner component to wire a new Windows MSSQL 2025 image secret and update step ownership.
Key changes
Practical impact