CNTRLPLANE-772: Add request serving test to HCM periodics#79884
Conversation
Enable REQUEST_SERVING_COMPONENT_TEST in the HCM periodic e2e-aws job to validate request-serving topology against real ROSA management clusters. The hypershift-aws-run-e2e-external-commands.sh script already supports this flag — this change only sets the env var in the job config. Related: openshift/hypershift#7031 (test implementation) Related: openshift#70989 (self-managed CI workflow)
openshift-ci-robot
added
the
jira/valid-reference
|
@jiezhao16: This pull request references CNTRLPLANE-772 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughAdds a new periodic test ChangesHyperShift Release 4.21 Periodic Tests
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/pj-rehearse periodic-ci-openshift-hypershift-release-4.21-periodics-hcm-e2e-aws |
|
@jiezhao16: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-hypershift-release-4.21-periodics-hcm-e2e-aws-request-serving |
|
@jiezhao16: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.21__periodics-hcm.yaml`:
- Around line 41-47: The new periodic job "e2e-aws-request-serving" was added to
ci-operator config but the generated Prow job artifacts under ci-operator/jobs
were not updated; run the repository's job generation (e.g., execute make update
or the project’s generation target) to regenerate Prow job configs, verify the
generated changes include the new periodic job, and commit those generated files
(or if generation intentionally yields no diffs, add a short note/evidence in
the PR describing why no generated changes occurred); ensure the job name
"e2e-aws-request-serving" appears in the regenerated artifacts before finalizing
the PR.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 3882d26e-43a1-4224-a023-259434eff010
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.21-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.21__periodics-hcm.yaml
Use the dedicated reqserving-e2e workflow which creates a standalone IPI cluster with MachineSets and autoscaler, matching production ROSA HCP topology more closely than the nested management cluster approach. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
There was a problem hiding this comment.
♻️ Duplicate comments (1)
ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.21__periodics-hcm.yaml (1)
41-47:⚠️ Potential issue | 🟠 Major | ⚡ Quick winRegenerate CI artifacts for the new periodic test entry.
This adds a new periodic test (
reqserving-e2e-aws), which is a structuralci-operator/configchange and should be accompanied by regeneratedci-operator/jobs/**output viamake update(or explicit evidence that generation is intentionally no-op).As per coding guidelines, “CI configuration files in
ci-operator/config/must be regenerated viamake updateafter modifications, which generates Prow job configs and validates configuration.”🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.21__periodics-hcm.yaml` around lines 41 - 47, You added a new periodic ci-operator config entry for reqserving-e2e-aws (workflow: hypershift-aws-reqserving-e2e) but did not regenerate derived job artifacts; run the repository generation step (invoke `make update`) to regenerate ci-operator/jobs/** and prow job outputs so the new periodic is reflected, then commit the updated generated files alongside the config change (or include a short note if generation is intentionally skipped).
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Duplicate comments:
In
`@ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.21__periodics-hcm.yaml`:
- Around line 41-47: You added a new periodic ci-operator config entry for
reqserving-e2e-aws (workflow: hypershift-aws-reqserving-e2e) but did not
regenerate derived job artifacts; run the repository generation step (invoke
`make update`) to regenerate ci-operator/jobs/** and prow job outputs so the new
periodic is reflected, then commit the updated generated files alongside the
config change (or include a short note if generation is intentionally skipped).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 00b7fc23-9b73-4725-a83f-1eb044e0773f
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/hypershift/openshift-hypershift-release-4.21-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift/hypershift/openshift-hypershift-release-4.21__periodics-hcm.yaml
|
/pj-rehearse periodic-ci-openshift-hypershift-release-4.21-periodics-hcm-reqserving-e2e-aws |
|
@jiezhao16: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse periodic-ci-openshift-hypershift-release-4.21-periodics-hcm-reqserving-e2e-aws |
|
@jiezhao16: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, jiezhao16 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse ack |
|
@jiezhao16: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
@jiezhao16: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
Bot
merged commit 7b3044d
into
openshift:main
3 participants
Summary
reqserving-e2e-awsperiodic job to the HCM periodics for 4.21hypershift-aws-reqserving-e2eworkflow which creates a standalone IPI cluster, installs HyperShift, configures MachineSets with autoscaler, and runs the full request-serving test suitereqserving-e2e-awsinopenshift-hypershift-main.yaml)TestCreateRequestServingIsolationClusterandTestControlPlaneAutoscalingIncreasesSizeRelated
Test plan
/pj-rehearseto verify the job runs successfully