Protect finops-tools branches#79863
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds two Prow configuration files for the ChangesProw automation setup for finops-tools
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Suggested labels
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: theute The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
openshift-merge-bot
Bot
added
the
rehearsals-ack
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@core-services/prow/02_config/openshift-online/finops-tools/_pluginconfig.yaml`:
- Around line 47-53: The triggers block contains an unsupported field
"org_invite: prominent: {}" which will fail strict Prow config validation;
remove the "org_invite: prominent: {}" entry from the triggers stanza (leave
valid keys like repos and trusted_apps unchanged) or, if this was intended for a
different plugin, move its configuration into the correct plugin's _pluginconfig
(search for usages of "org_invite" to confirm intent). Target the triggers block
surrounding the "triggers", "org_invite: prominent", "repos: -
openshift-online/finops-tools", and "trusted_apps: - openshift-merge-bot"
symbols when making the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: ed4a12cc-7ed9-4a4e-add3-f072550ec3ef
📒 Files selected for processing (2)
core-services/prow/02_config/openshift-online/finops-tools/_pluginconfig.yamlcore-services/prow/02_config/openshift-online/finops-tools/_prowconfig.yaml
| triggers: | ||
| - org_invite: | ||
| prominent: {} | ||
| repos: | ||
| - openshift-online/finops-tools | ||
| trusted_apps: | ||
| - openshift-merge-bot |
There was a problem hiding this comment.
org_invite is not a recognized field of the trigger plugin config.
The Prow trigger plugin's Trigger struct only accepts repos, trusted_apps, trusted_org, join_org_url, only_org_members, ignore_ok_to_test, and trigger_github_workflows. org_invite: prominent: {} is not part of this schema, so strict config validation (checkconfig) may reject this entry. trusted_apps/repos here are valid; please confirm whether org_invite is intended/supported, and drop it if not.
🔍 Proposed fix if `org_invite` is not supported
triggers:
-- org_invite:
- prominent: {}
- repos:
+- repos:
- openshift-online/finops-tools
trusted_apps:
- openshift-merge-botCheck whether org_invite is used by any other Prow plugin config in this repo (broad usage would suggest a recognized/forked field, none would corroborate a typo/misplacement):
#!/bin/bash
# Look for other `org_invite` usages across Prow plugin configs
rg -nP -C3 'org_invite' --iglob '**/_pluginconfig.yaml'🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@core-services/prow/02_config/openshift-online/finops-tools/_pluginconfig.yaml`
around lines 47 - 53, The triggers block contains an unsupported field
"org_invite: prominent: {}" which will fail strict Prow config validation;
remove the "org_invite: prominent: {}" entry from the triggers stanza (leave
valid keys like repos and trusted_apps unchanged) or, if this was intended for a
different plugin, move its configuration into the correct plugin's _pluginconfig
(search for usages of "org_invite" to confirm intent). Target the triggers block
surrounding the "triggers", "org_invite: prominent", "repos: -
openshift-online/finops-tools", and "trusted_apps: - openshift-merge-bot"
symbols when making the change.
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@theute: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
This might be overkill but we'll see...
Primary intent is to protect the 'main' branch for direct commit and have reviewers/approvers
Summary by CodeRabbit
This change adds Prow configuration to protect and enforce review policies for the openshift-online/finops-tools repository.
Practical impact:
Result: The main branch for finops-tools is now protected against direct commits and requires reviewer approval and label-based gating before Tide will merge, enforcing stricter review discipline and automated merge controls.